Bug 117022 - Rename FontFallbackList.cpp/h to FontGlyphs.cpp/h
Summary: Rename FontFallbackList.cpp/h to FontGlyphs.cpp/h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-30 02:23 PDT by Antti Koivisto
Modified: 2013-05-30 03:44 PDT (History)
4 users (show)

See Also:

Attachments
patch (836.65 KB, patch)
2013-05-30 02:51 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
actual patch (62.18 KB, patch)
2013-05-30 03:08 PDT, Antti Koivisto 		kling: review+
webkit-ews: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2013-05-30 02:23:32 PDT 
Match the new class name.
Comment 1 Antti Koivisto 2013-05-30 02:51:07 PDT 
Created attachment 203328 [details]
patch
Comment 2 WebKit Commit Bot 2013-05-30 02:52:58 PDT 
Attachment 203328 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files']" exit_code: 1
Total errors found: 0 in 0 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Antti Koivisto 2013-05-30 03:08:30 PDT 
Created attachment 203334 [details]
actual patch

that was the ChangeLog
Comment 4 Andreas Kling 2013-05-30 03:11:01 PDT 
Comment on attachment 203334 [details]
actual patch

r=me

*braces for mitzslap*
Comment 5 WebKit Commit Bot 2013-05-30 03:12:51 PDT 
Attachment 203334 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Target.pri', u'Source/WebCore/WebCore.vcproj/WebCore.vcproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/platform/graphics/Font.h', u'Source/WebCore/platform/graphics/FontCache.cpp', u'Source/WebCore/platform/graphics/FontFallbackList.cpp', u'Source/WebCore/platform/graphics/FontFallbackList.h', u'Source/WebCore/platform/graphics/FontFastPath.cpp', u'Source/WebCore/platform/graphics/FontGlyphs.cpp', u'Source/WebCore/platform/graphics/FontGlyphs.h', u'Source/WebCore/platform/graphics/mac/FontComplexTextMac.cpp']" exit_code: 1
Source/WebCore/platform/graphics/FontGlyphs.cpp:106:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/platform/graphics/FontGlyphs.cpp:107:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Total errors found: 2 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Early Warning System Bot 2013-05-30 03:17:22 PDT 
Comment on attachment 203334 [details]
actual patch

Attachment 203334 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/751318
Comment 7 Early Warning System Bot 2013-05-30 03:19:56 PDT 
Comment on attachment 203334 [details]
actual patch

Attachment 203334 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/683563
Comment 8 Build Bot 2013-05-30 03:39:13 PDT 
Comment on attachment 203334 [details]
actual patch

Attachment 203334 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/726231
Comment 9 Antti Koivisto 2013-05-30 03:44:54 PDT 
http://trac.webkit.org/changeset/150956 (with built fixes)