RESOLVED FIXED 117019
Avoid using CSSOM style declarations in HTML editing. 
https://bugs.webkit.org/show_bug.cgi?id=117019
Summary Avoid using CSSOM style declarations in HTML editing.
Andreas Kling
Reported 2013-05-30 00:50:27 PDT
We should use ComputedStyleExtractor instead.
Attachments
Snack for EWS (37.19 KB, patch)
2013-05-30 00:51 PDT, Andreas Kling 		webkit-ews: commit-queue-
DetailsFormatted DiffDiff
Dessert for EWS (38.48 KB, patch)
2013-05-30 00:57 PDT, Andreas Kling 		webkit-ews: commit-queue-
DetailsFormatted DiffDiff
Salad for EWS (37.51 KB, patch)
2013-05-30 01:36 PDT, Andreas Kling 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Pretentious patch (38.52 KB, patch)
2013-05-30 02:58 PDT, Andreas Kling 		koivisto: review+
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2013-05-30 00:51:00 PDT
Created attachment 203318 [details] Snack for EWS
Early Warning System Bot
Comment 2 2013-05-30 00:56:57 PDT
Comment on attachment 203318 [details] Snack for EWS Attachment 203318 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/692349
Andreas Kling
Comment 3 2013-05-30 00:57:12 PDT
Created attachment 203320 [details] Dessert for EWS
Early Warning System Bot
Comment 4 2013-05-30 01:04:17 PDT
Comment on attachment 203320 [details] Dessert for EWS Attachment 203320 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/675672
Early Warning System Bot
Comment 5 2013-05-30 01:04:28 PDT
Comment on attachment 203320 [details] Dessert for EWS Attachment 203320 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/751283
Build Bot
Comment 6 2013-05-30 01:28:18 PDT
Comment on attachment 203320 [details] Dessert for EWS Attachment 203320 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/726204
Andreas Kling
Comment 7 2013-05-30 01:36:07 PDT
Created attachment 203323 [details] Salad for EWS
Build Bot
Comment 8 2013-05-30 01:51:18 PDT
Comment on attachment 203323 [details] Salad for EWS Attachment 203323 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/742354
Build Bot
Comment 9 2013-05-30 01:54:29 PDT
Comment on attachment 203323 [details] Salad for EWS Attachment 203323 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/665605
kov's GTK+ EWS bot
Comment 10 2013-05-30 01:54:56 PDT
Comment on attachment 203323 [details] Salad for EWS Attachment 203323 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/683538
Andreas Kling
Comment 11 2013-05-30 02:58:10 PDT
Created attachment 203330 [details] Pretentious patch
Antti Koivisto
Comment 12 2013-05-30 03:31:32 PDT
Comment on attachment 203330 [details] Pretentious patch View in context: https://bugs.webkit.org/attachment.cgi?id=203330&action=review > Source/WebCore/ChangeLog:60 > + (WebCore::getPropertyValue): > + (WebCore::getIdentifierValue): > + (WebCore::getRGBAFontColor): > + (WebCore::getRGBABackgroundColor): Would be nice to use webkit naming style here (get* is only used for functions that return value in argument). > Source/WebCore/ChangeLog:70 > + (WebCore::getPropertiesNotIn): Here too.
Andreas Kling
Comment 13 2013-05-30 05:53:18 PDT
Committed r150960: <http://trac.webkit.org/changeset/150960>
Note You need to log in before you can comment on or make changes to this bug.