Bug 117017 - Remove obsolete forward declaration from InspectorFrontendHost.h
Summary: Remove obsolete forward declaration from InspectorFrontendHost.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-30 00:17 PDT by Seokju Kwon
Modified: 2013-05-30 01:14 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.70 KB, patch)
2013-05-30 00:21 PDT, Seokju Kwon 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Seokju Kwon 2013-05-30 00:17:14 PDT 
SSIA
Comment 1 Seokju Kwon 2013-05-30 00:19:31 PDT 
Fix style issue as well.
Source/WebCore/inspector/InspectorFrontendHost.h:105:  The parameter name "client" adds no information, so it should be removed.
Comment 2 Seokju Kwon 2013-05-30 00:21:42 PDT 
Created attachment 203314 [details]
Patch
Comment 3 Joseph Pecoraro 2013-05-30 00:51:54 PDT 
Comment on attachment 203314 [details]
Patch

There might be plenty of this in Inspector files. Removing unnecessary includes could even improve build times. This simple cleanup seems fine. r=me
Comment 4 Joseph Pecoraro 2013-05-30 00:52:27 PDT 
Comment on attachment 203314 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=203314&action=review

> Source/WebCore/ChangeLog:14
> +        (WebCore):
> +        (InspectorFrontendHost):

In the future, you can delete these lines from ChangeLogs. They are useless. I believe someone is working on fixing prepare-ChangeLog to no longer include them.
Comment 5 Seokju Kwon 2013-05-30 01:12:40 PDT 
(In reply to comment #4)
> (From update of attachment 203314 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=203314&action=review
> 
> > Source/WebCore/ChangeLog:14
> > +        (WebCore):
> > +        (InspectorFrontendHost):
> 
> In the future, you can delete these lines from ChangeLogs. They are useless. I believe someone is working on fixing prepare-ChangeLog to no longer include them.

Ok. Thanks.
Comment 6 WebKit Commit Bot 2013-05-30 01:14:19 PDT 
Comment on attachment 203314 [details]
Patch

Clearing flags on attachment: 203314

Committed r150953: <http://trac.webkit.org/changeset/150953>
Comment 7 WebKit Commit Bot 2013-05-30 01:14:21 PDT 
All reviewed patches have been landed.  Closing bug.