Bug 117016 - HTMLMediaElement will not unthrottle page when playback stops for nreasons other than user-initiated pause.
Summary: HTMLMediaElement will not unthrottle page when playback stops for nreasons ot...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-05-29 22:38 PDT by Jer Noble
Modified: 2013-05-30 11:18 PDT (History)
13 users (show)

See Also:

Attachments
Patch (22.89 KB, patch)
2013-05-30 00:34 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (22.91 KB, patch)
2013-05-30 00:46 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2013-05-29 22:38:17 PDT 
HTMLMediaElement will not unthrottle page when playback stops for nreasons other than user-initiated pause.
Comment 1 Jer Noble 2013-05-29 22:40:06 PDT 
PageThrottler was introduced by http://trac.webkit.org/changeset/150935, a fix for bug #116893. The unthrottling case will only be triggered for user or script initiated "pause()", but will not unthrottle when stopped due to network congestion, media engine errors, or when the media plays to the end of its duration.
Comment 2 Jer Noble 2013-05-29 23:22:02 PDT 
<rdar://problem/14020751>
Comment 3 Jer Noble 2013-05-30 00:34:24 PDT 
Created attachment 203316 [details]
Patch
Comment 4 EFL EWS Bot 2013-05-30 00:40:30 PDT 
Comment on attachment 203316 [details]
Patch

Attachment 203316 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/759050
Comment 5 kov's GTK+ EWS bot 2013-05-30 00:40:55 PDT 
Comment on attachment 203316 [details]
Patch

Attachment 203316 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/675666
Comment 6 EFL EWS Bot 2013-05-30 00:41:54 PDT 
Comment on attachment 203316 [details]
Patch

Attachment 203316 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/658302
Comment 7 Early Warning System Bot 2013-05-30 00:43:12 PDT 
Comment on attachment 203316 [details]
Patch

Attachment 203316 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/673309
Comment 8 Jer Noble 2013-05-30 00:46:56 PDT 
Created attachment 203317 [details]
Patch

Use nullptr for clearing OwnPtr rather than 0.
Comment 9 Jer Noble 2013-05-30 11:18:45 PDT 
Comment on attachment 203317 [details]
Patch

Clearing flags on attachment: 203317

Committed r150971: <http://trac.webkit.org/changeset/150971>
Comment 10 Jer Noble 2013-05-30 11:18:49 PDT 
All reviewed patches have been landed.  Closing bug.