Bug 117015 - Expose incrementalRenderingSuppressionTimeoutInSeconds via WK2
Summary: Expose incrementalRenderingSuppressionTimeoutInSeconds via WK2
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-05-29 22:36 PDT by Tim Horton
Modified: 2013-05-29 23:24 PDT (History)
6 users (show)

See Also:


Attachments
patch (10.93 KB, patch)
2013-05-29 23:02 PDT, Tim Horton
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2013-05-29 22:36:05 PDT
And also make the timeout work with WK2.

And make it work with incremental rendering suppression tokens.

Basically, this is "make the incremental rendering timeout work with all the WK2 bits".

<rdar://problem/13992853>
Comment 1 Tim Horton 2013-05-29 23:02:11 PDT
Created attachment 203311 [details]
patch
Comment 2 Darin Adler 2013-05-29 23:11:37 PDT
Comment on attachment 203311 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=203311&action=review

> Source/WebKit2/UIProcess/API/C/WKPreferencesPrivate.h:286
> +// Defaults to 5 seconds

We put periods on these kinds of fragments, usually.

> Source/WebKit2/UIProcess/API/C/WKPreferencesPrivate.h:288
> +WK_EXPORT void WKPreferencesSetIncrementalRenderingSuppressionTimeoutInSeconds(WKPreferencesRef preferencesRef, double timeout);
> +WK_EXPORT double WKPreferencesGetIncrementalRenderingSuppressionTimeoutInSeconds(WKPreferencesRef preferencesRef);

Does “in seconds” really need to be in the function name? We use seconds for all our WebKit time units, don’t we? And it’s also the standard in Cocoa. Maybe the argument name would be sufficient?
Comment 3 Tim Horton 2013-05-29 23:17:42 PDT
(In reply to comment #2)
> (From update of attachment 203311 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=203311&action=review
> 
> > Source/WebKit2/UIProcess/API/C/WKPreferencesPrivate.h:286
> > +// Defaults to 5 seconds
> 
> We put periods on these kinds of fragments, usually.

Indeed! That file is amazingly inconsistent on this point. I'll add periods to mine.

> > Source/WebKit2/UIProcess/API/C/WKPreferencesPrivate.h:288
> > +WK_EXPORT void WKPreferencesSetIncrementalRenderingSuppressionTimeoutInSeconds(WKPreferencesRef preferencesRef, double timeout);
> > +WK_EXPORT double WKPreferencesGetIncrementalRenderingSuppressionTimeoutInSeconds(WKPreferencesRef preferencesRef);
> 
> Does “in seconds” really need to be in the function name? We use seconds for all our WebKit time units, don’t we? And it’s also the standard in Cocoa. Maybe the argument name would be sufficient?

Probably not, I was just matching the WebCore setting name. I'll drop the InSeconds from the WK2 SPI.

Thanks!
Comment 4 Tim Horton 2013-05-29 23:24:54 PDT
http://trac.webkit.org/changeset/150950