Bug 117015 – Expose incrementalRenderingSuppressionTimeoutInSeconds via WK2

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Tim Horton]

And also make the timeout work with WK2.

And make it work with incremental rendering suppression tokens.

Basically, this is "make the incremental rendering timeout work with all the WK2 bits".

<rdar://problem/13992853>

[Tim Horton]

Created attachment 203311 [details]
patch

[Darin Adler]

Comment on attachment 203311 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=203311&action=review

> Source/WebKit2/UIProcess/API/C/WKPreferencesPrivate.h:286
> +// Defaults to 5 seconds

We put periods on these kinds of fragments, usually.

> Source/WebKit2/UIProcess/API/C/WKPreferencesPrivate.h:288
> +WK_EXPORT void WKPreferencesSetIncrementalRenderingSuppressionTimeoutInSeconds(WKPreferencesRef preferencesRef, double timeout);
> +WK_EXPORT double WKPreferencesGetIncrementalRenderingSuppressionTimeoutInSeconds(WKPreferencesRef preferencesRef);

Does “in seconds” really need to be in the function name? We use seconds for all our WebKit time units, don’t we? And it’s also the standard in Cocoa. Maybe the argument name would be sufficient?

[Tim Horton]

(In reply to comment #2)
> (From update of attachment 203311 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=203311&action=review
> 
> > Source/WebKit2/UIProcess/API/C/WKPreferencesPrivate.h:286
> > +// Defaults to 5 seconds
> 
> We put periods on these kinds of fragments, usually.

Indeed! That file is amazingly inconsistent on this point. I'll add periods to mine.

> > Source/WebKit2/UIProcess/API/C/WKPreferencesPrivate.h:288
> > +WK_EXPORT void WKPreferencesSetIncrementalRenderingSuppressionTimeoutInSeconds(WKPreferencesRef preferencesRef, double timeout);
> > +WK_EXPORT double WKPreferencesGetIncrementalRenderingSuppressionTimeoutInSeconds(WKPreferencesRef preferencesRef);
> 
> Does “in seconds” really need to be in the function name? We use seconds for all our WebKit time units, don’t we? And it’s also the standard in Cocoa. Maybe the argument name would be sufficient?

Probably not, I was just matching the WebCore setting name. I'll drop the InSeconds from the WK2 SPI.

Thanks!

[Tim Horton]

http://trac.webkit.org/changeset/150950