Bug 117009 – Update CheckedInt.h to latest version from Mozilla

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Dean Jackson]

Benoit Jacob contacted me to say the version of CheckedInt.h in WebKit is out of date. Mozilla and Blink have updated.

[Dean Jackson]

Created attachment 203291 [details]
Patch

[WebKit Commit Bot]

Attachment 203291 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/html/canvas/CheckedInt.h']" exit_code: 1
Source/WebCore/html/canvas/CheckedInt.h:105:  More than one command on the same line  [whitespace/newline] [4]
Source/WebCore/html/canvas/CheckedInt.h:137:  More than one command on the same line  [whitespace/newline] [4]
Source/WebCore/html/canvas/CheckedInt.h:141:  More than one command on the same line  [whitespace/newline] [4]
Source/WebCore/html/canvas/CheckedInt.h:395:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/html/canvas/CheckedInt.h:468:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/html/canvas/CheckedInt.h:469:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/html/canvas/CheckedInt.h:470:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Source/WebCore/html/canvas/CheckedInt.h:470:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/html/canvas/CheckedInt.h:479:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/html/canvas/CheckedInt.h:480:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/html/canvas/CheckedInt.h:481:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/html/canvas/CheckedInt.h:483:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/html/canvas/CheckedInt.h:571:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/html/canvas/CheckedInt.h:571:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/html/canvas/CheckedInt.h:572:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/WebCore/html/canvas/CheckedInt.h:595:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/html/canvas/CheckedInt.h:595:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/html/canvas/CheckedInt.h:596:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/WebCore/html/canvas/CheckedInt.h:647:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/html/canvas/CheckedInt.h:767:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/html/canvas/CheckedInt.h:767:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/html/canvas/CheckedInt.h:768:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Total errors found: 22 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 203291 [details]
Patch

Attachment 203291 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/658243

[Ryosuke Niwa]

Comment on attachment 203291 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=203291&action=review

> Source/WebCore/ChangeLog:14
> +        Bug 869194.

Maybe include the bug URL here?

[Build Bot]

Comment on attachment 203291 [details]
Patch

Attachment 203291 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/692293

[Dean Jackson]

Fails to build :(

[Dean Jackson]

(In reply to comment #4)
> (From update of attachment 203291 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=203291&action=review
> 
> > Source/WebCore/ChangeLog:14
> > +        Bug 869194.
> 
> Maybe include the bug URL here?

Sure!

[Dean Jackson]

Created attachment 203295 [details]
Patch

[WebKit Commit Bot]

Attachment 203295 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/html/canvas/CheckedInt.h']" exit_code: 1
Source/WebCore/html/canvas/CheckedInt.h:106:  More than one command on the same line  [whitespace/newline] [4]
Source/WebCore/html/canvas/CheckedInt.h:138:  More than one command on the same line  [whitespace/newline] [4]
Source/WebCore/html/canvas/CheckedInt.h:142:  More than one command on the same line  [whitespace/newline] [4]
Source/WebCore/html/canvas/CheckedInt.h:396:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/html/canvas/CheckedInt.h:469:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/html/canvas/CheckedInt.h:470:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/html/canvas/CheckedInt.h:471:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Source/WebCore/html/canvas/CheckedInt.h:471:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/html/canvas/CheckedInt.h:480:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/html/canvas/CheckedInt.h:481:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/html/canvas/CheckedInt.h:482:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/html/canvas/CheckedInt.h:484:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/html/canvas/CheckedInt.h:572:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/html/canvas/CheckedInt.h:572:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/html/canvas/CheckedInt.h:573:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/WebCore/html/canvas/CheckedInt.h:596:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/html/canvas/CheckedInt.h:596:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/html/canvas/CheckedInt.h:597:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/WebCore/html/canvas/CheckedInt.h:648:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/html/canvas/CheckedInt.h:768:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/html/canvas/CheckedInt.h:768:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/html/canvas/CheckedInt.h:769:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Total errors found: 22 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Oliver Hunt]

What is WTF/CheckedArithmetic.h missing that means we need a separate implementation of checked arithmetic?

[Dean Jackson]

(In reply to comment #10)
> What is WTF/CheckedArithmetic.h missing that means we need a separate implementation of checked arithmetic?

I don't know. Maybe you should file a bug?

[Dean Jackson]

Committed r151029: <http://trac.webkit.org/changeset/151029>