Bug 117001 – WebKit's Enter Full Screen for <video> elements isn't working

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Ruth Fong]

When hooking into WK's context menu action for entering into full screen for <video> elements, nothing happens (as opposed to hooking into WK's other media context menu actions, such as mute).

[Ruth Fong]

<rdar://problem/14006095>

[Ruth Fong]

Created attachment 203372 [details]
Patch

[Darin Adler]

Comment on attachment 203372 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=203372&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests. Covered by existing tests for fullscreen.

If this is covered by existing tests, why aren’t those tests failing?

[Jer Noble]

Comment on attachment 203372 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=203372&action=review

> Source/WebCore/dom/Document.cpp:4980
> +    UserGestureIndicator indicator(DefinitelyProcessingNewUserGesture);
> +    

By inserting this UserGestureIndicator, this patch would disable the security requirement that full screen requests must begin with an event handler.  The appropriate place to put this line is in your context menu handler, immediately before calling element->webkitRequestFullScreen(), not inside requestFullScreenForElement() itself.

[Ruth Fong]

Created attachment 203396 [details]
Patch

[Jer Noble]

Comment on attachment 203396 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=203396&action=review

> Source/WebCore/ChangeLog:11
> +        No new tests.
> +
> +        * rendering/HitTestResult.cpp:
> +        (WebCore::HitTestResult::enterFullscreenForVideo):

Please describe the problem which this patch is trying to solve, and why the approach here fixes the problem.

You should also explain why no new tests were added: i.e, there is an existing test, media/context-menu-actions.html, but it is disabled due to bug #116651.

[Ruth Fong]

Created attachment 203400 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 203400 [details]
Patch

Clearing flags on attachment: 203400

Committed r151003: <http://trac.webkit.org/changeset/151003>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.