Bug 116998 - [Windows] Be consistent with allocation/deallocation behavior
Summary: [Windows] Be consistent with allocation/deallocation behavior
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-05-29 14:20 PDT by Brent Fulgham
Modified: 2013-05-29 14:28 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.49 KB, patch)
2013-05-29 14:22 PDT, Brent Fulgham 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2013-05-29 14:20:25 PDT 
Running a Visual Studio 2010 build of DumpRenderTree can crash when using WebPreferences if a non-2010 runtime library is deallocating the memory.

This patch adjusts the behavior of the WebPreferences implementation to use the library allocator rather than overriding to use the current CRT allocator so that future cleanup can be done by the same runtime library.
Comment 1 Brent Fulgham 2013-05-29 14:22:26 PDT 
Created attachment 203276 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2013-05-29 14:23:37 PDT 
<rdar://problem/14016391>
Comment 3 Brent Fulgham 2013-05-29 14:28:16 PDT 
Committed r150930: <http://trac.webkit.org/changeset/150930>