Bug 116997 - [CSS Shapes] Layout correctly the bottom positioned shapes in flowthreads
Summary: [CSS Shapes] Layout correctly the bottom positioned shapes in flowthreads
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zoltan Horvath
URL:
Keywords:
Depends on:
Blocks: 89256
  Show dependency treegraph
 
Reported: 2013-05-29 14:14 PDT by Zoltan Horvath
Modified: 2013-06-13 09:26 PDT (History)
6 users (show)

See Also:


Attachments
proposed patch (19.24 KB, patch)
2013-05-29 14:22 PDT, Zoltan Horvath
no flags Details | Formatted Diff | Diff
improved and updated patch (21.15 KB, patch)
2013-06-07 09:50 PDT, Zoltan Horvath
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2 (725.56 KB, application/zip)
2013-06-07 18:46 PDT, Build Bot
no flags Details
proposed patch (21.22 KB, patch)
2013-06-10 14:36 PDT, Zoltan Horvath
no flags Details | Formatted Diff | Diff
updated patch after r151402 (20.86 KB, patch)
2013-06-10 15:07 PDT, Zoltan Horvath
buildbot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zoltan Horvath 2013-05-29 14:14:35 PDT
In r150478 I added support for multiple positioned shape-insides on regions, this patch covers cases when a shape is positioned to the bottom of the region. I added a new helper function for the calculation of the line boundaries in the flow thread cases.
Comment 1 Zoltan Horvath 2013-05-29 14:22:34 PDT
Created attachment 203277 [details]
proposed patch
Comment 2 Zoltan Horvath 2013-06-06 10:39:13 PDT
Comment on attachment 203277 [details]
proposed patch

This patch is not going to apply on the trunk anymore. I'm going to upload a new version of it soon.
Comment 3 Zoltan Horvath 2013-06-07 09:50:06 PDT
Created attachment 204048 [details]
improved and updated patch
Comment 4 Build Bot 2013-06-07 18:46:45 PDT
Comment on attachment 204048 [details]
improved and updated patch

Attachment 204048 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/767025

New failing tests:
fast/regions/offsetLeft-offsetTop-in-region-float.html
fast/multicol/transform-inside-opacity.html
http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame.html
fast/regions/hover-single-flow-from-other.html
fast/regions/counters/extract-numbered-spans-display-only-some.html
fast/multicol/newmulticol/float-paginate.html
http/tests/security/cross-origin-plugin-private-browsing-toggled.html
fast/regions/moved-content-node-crash.html
http/tests/inspector/inspect-element.html
fast/multicol/newmulticol/layers-in-multicol.html
fast/multicol/mixed-positioning-stacking-order.html
fast/regions/fixed-pos-elem-in-named-flow2.html
editing/pasteboard/copy-image-with-alt-text.html
fast/multicol/newmulticol/float-paginate-complex.html
editing/pasteboard/smart-paste-001.html
fast/regions/offsetParent-body-in-flow-thread.html
fast/multicol/newmulticol/float-paginate-empty-lines.html
fast/regions/fixed-pos-elem-in-named-flow.html
fast/table/table-section-node-at-point-crash.html
fast/regions/hover-single-flow-from-none.html
fast/multicol/newmulticol/layers-split-across-columns.html
fast/multicol/newmulticol/positioned-split.html
fast/multicol/newmulticol/column-rules-fixed-height.html
fast/multicol/newmulticol/positioned-with-constrained-height.html
fast/regions/offsetLeft-offsetTop-in-region-float-vert-rl.html
fast/regions/line-containing-region-crash.html
fast/regions/absolute-pos-elem-in-named-flow.html
Comment 5 Build Bot 2013-06-07 18:46:48 PDT
Created attachment 204079 [details]
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-12  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.3
Comment 6 Zoltan Horvath 2013-06-10 10:33:33 PDT
I didn't experience these errors on 10.8.3.
Comment 7 Zoltan Horvath 2013-06-10 14:36:50 PDT
Created attachment 204189 [details]
proposed patch
Comment 8 Zoltan Horvath 2013-06-10 15:07:40 PDT
Created attachment 204217 [details]
updated patch after r151402
Comment 9 Build Bot 2013-06-11 05:41:09 PDT
Comment on attachment 204217 [details]
updated patch after r151402

Attachment 204217 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/832025
Comment 10 Zoltan Horvath 2013-06-13 09:26:28 PDT
I close this as invalid, I merged the patch with the adjustments fix in: bug #117599