Bug 116969 - [BlackBerry] Handle Host-Only cookies
Summary: [BlackBerry] Handle Host-Only cookies
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-29 09:48 PDT by otcheung
Modified: 2013-05-29 11:46 PDT (History)
1 user (show)

See Also:

Attachments
Patch (7.73 KB, patch)
2013-05-29 09:57 PDT, otcheung 		no flags Details | Formatted Diff | Diff
Patch (7.77 KB, patch)
2013-05-29 09:58 PDT, otcheung 		no flags Details | Formatted Diff | Diff
Patch (8.39 KB, patch)
2013-05-29 11:17 PDT, otcheung 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description otcheung 2013-05-29 09:48:54 PDT 
Patch to support host-only cookies.
Comment 1 otcheung 2013-05-29 09:57:11 PDT 
Created attachment 203209 [details]
Patch
Comment 2 otcheung 2013-05-29 09:58:16 PDT 
Created attachment 203211 [details]
Patch
Comment 3 Rob Buis 2013-05-29 10:07:02 PDT 
Comment on attachment 203211 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=203211&action=review

Please try StringBuilder.

> Source/WebCore/platform/blackberry/CookieParser.cpp:270
> +                String defaultHost = "." + m_defaultCookieHost;

Using StringBuilder should be more efficient.
Comment 4 otcheung 2013-05-29 11:17:56 PDT 
Created attachment 203220 [details]
Patch
Comment 5 Rob Buis 2013-05-29 11:21:10 PDT 
Comment on attachment 203220 [details]
Patch

Looks good.
Comment 6 WebKit Commit Bot 2013-05-29 11:46:31 PDT 
Comment on attachment 203220 [details]
Patch

Clearing flags on attachment: 203220

Committed r150916: <http://trac.webkit.org/changeset/150916>
Comment 7 WebKit Commit Bot 2013-05-29 11:46:32 PDT 
All reviewed patches have been landed.  Closing bug.