RESOLVED FIXED 116968
Take ComputedStyleExtractor for a spin. 
https://bugs.webkit.org/show_bug.cgi?id=116968
Summary Take ComputedStyleExtractor for a spin.
Andreas Kling
Reported 2013-05-29 09:42:21 PDT
Take ComputedStyleExtractor for a spin.
Attachments
Patch (11.53 KB, patch)
2013-05-29 09:42 PDT, Andreas Kling 		webkit-ews: commit-queue-
DetailsFormatted DiffDiff
Patch (11.55 KB, patch)
2013-05-29 09:51 PDT, Andreas Kling 		koivisto: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2013-05-29 09:42:55 PDT
Created attachment 203206 [details] Patch
Early Warning System Bot
Comment 2 2013-05-29 09:48:59 PDT
Comment on attachment 203206 [details] Patch Attachment 203206 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/742188
Early Warning System Bot
Comment 3 2013-05-29 09:51:07 PDT
Comment on attachment 203206 [details] Patch Attachment 203206 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/750227
Andreas Kling
Comment 4 2013-05-29 09:51:45 PDT
Created attachment 203208 [details] Patch
Antti Koivisto
Comment 5 2013-05-29 11:22:46 PDT
Comment on attachment 203208 [details] Patch r=me
Antti Koivisto
Comment 6 2013-05-29 11:30:14 PDT
Comment on attachment 203208 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=203208&action=review > Source/WebCore/editing/ApplyStyleCommand.cpp:459 > + int unicodeBidi = getIdentifierValue(ComputedStyleExtractor(n), CSSPropertyUnicodeBidi); Why does getIdentifierValue take ComputedStyleExtractor instead of a node? Seems unnecessarily abstract.
Andreas Kling
Comment 7 2013-05-29 21:11:39 PDT
Committed r150945: <http://trac.webkit.org/changeset/150945>
Note You need to log in before you can comment on or make changes to this bug.