Bug 116959 - [EFl][WK2] Sub menu items should be of EWK_SUBMENU_TYPE and not checkable
Summary: [EFl][WK2] Sub menu items should be of EWK_SUBMENU_TYPE and not checkable
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Michal Pakula vel Rutka
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-29 06:07 PDT by Michal Pakula vel Rutka
Modified: 2013-06-04 07:02 PDT (History)
5 users (show)

See Also:

Attachments
patch (5.59 KB, patch)
2013-05-29 06:22 PDT, Michal Pakula vel Rutka 		gyuyoung.kim: review+
Details | Formatted Diff | Diff
fixed changelog (5.68 KB, patch)
2013-06-04 05:07 PDT, Michal Pakula vel Rutka 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michal Pakula vel Rutka 2013-05-29 06:07:49 PDT 
Currently using ewk API it is possible to create a sub menu item which is not an EWK_SUBMENU_TYPE or set checkable flag for it, while it is not possible for items created by WebKit. This patch changes ewk context menu API to match WebKit behaviour, by creating sub menus with proper type and checkable flags.
Comment 1 Michal Pakula vel Rutka 2013-05-29 06:22:29 PDT 
Created attachment 203190 [details]
patch
Comment 2 Gyuyoung Kim 2013-06-04 04:53:13 PDT 
Comment on attachment 203190 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=203190&action=review

LGTM. This patch follows a policy of WK2 Context menu C APIs.

> Source/WebKit2/ChangeLog:10
> +        This patch changes ewk context menu API to match WebKit behaviour, by creating sub menus with

WebKit behaviour -> WebKit2 behaviour ? It looks WebKit1 has other behaviour differ from port to port.

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_context_menu.cpp:103
> +    Ewk_Context_Menu_Item* newItem3 = ewk_context_menu_item_new_with_submenu(EWK_CONTEXT_MENU_ITEM_TAG_OTHER, "New Custom Item 3", true, subMenu2);

Isn't it better to use other action ?
Comment 3 Michal Pakula vel Rutka 2013-06-04 05:00:54 PDT 
(In reply to comment #2)
> (From update of attachment 203190 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=203190&action=review
> 
> LGTM. This patch follows a policy of WK2 Context menu C APIs.
> 
> > Source/WebKit2/ChangeLog:10
> > +        This patch changes ewk context menu API to match WebKit behaviour, by creating sub menus with
> 
> WebKit behaviour -> WebKit2 behaviour ? It looks WebKit1 has other behaviour differ from port to port.

Ok I will fix it.

> 
> > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_context_menu.cpp:103
> > +    Ewk_Context_Menu_Item* newItem3 = ewk_context_menu_item_new_with_submenu(EWK_CONTEXT_MENU_ITEM_TAG_OTHER, "New Custom Item 3", true, subMenu2);
> 
> Isn't it better to use other action ?

I am fix context menu API tests in this bug https://bugs.webkit.org/show_bug.cgi?id=116601. There I am changing TAG_OTHER to TAG_CUSTOM as TAG_OTHER seems to be some kind of WebKit-GTK specific tag.
Comment 4 Michal Pakula vel Rutka 2013-06-04 05:07:04 PDT 
Created attachment 203684 [details]
fixed changelog
Comment 5 WebKit Commit Bot 2013-06-04 07:02:09 PDT 
Comment on attachment 203684 [details]
fixed changelog

Clearing flags on attachment: 203684

Committed r151168: <http://trac.webkit.org/changeset/151168>
Comment 6 WebKit Commit Bot 2013-06-04 07:02:14 PDT 
All reviewed patches have been landed.  Closing bug.