Bug 116959 – [EFl][WK2] Sub menu items should be of EWK_SUBMENU_TYPE and not checkable

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Michal Pakula vel Rutka]

Currently using ewk API it is possible to create a sub menu item which is not an EWK_SUBMENU_TYPE or set checkable flag for it, while it is not possible for items created by WebKit. This patch changes ewk context menu API to match WebKit behaviour, by creating sub menus with proper type and checkable flags.

[Michal Pakula vel Rutka]

Created attachment 203190 [details]
patch

[Gyuyoung Kim]

Comment on attachment 203190 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=203190&action=review

LGTM. This patch follows a policy of WK2 Context menu C APIs.

> Source/WebKit2/ChangeLog:10
> +        This patch changes ewk context menu API to match WebKit behaviour, by creating sub menus with

WebKit behaviour -> WebKit2 behaviour ? It looks WebKit1 has other behaviour differ from port to port.

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_context_menu.cpp:103
> +    Ewk_Context_Menu_Item* newItem3 = ewk_context_menu_item_new_with_submenu(EWK_CONTEXT_MENU_ITEM_TAG_OTHER, "New Custom Item 3", true, subMenu2);

Isn't it better to use other action ?

[Michal Pakula vel Rutka]

(In reply to comment #2)
> (From update of attachment 203190 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=203190&action=review
> 
> LGTM. This patch follows a policy of WK2 Context menu C APIs.
> 
> > Source/WebKit2/ChangeLog:10
> > +        This patch changes ewk context menu API to match WebKit behaviour, by creating sub menus with
> 
> WebKit behaviour -> WebKit2 behaviour ? It looks WebKit1 has other behaviour differ from port to port.

Ok I will fix it.

> 
> > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_context_menu.cpp:103
> > +    Ewk_Context_Menu_Item* newItem3 = ewk_context_menu_item_new_with_submenu(EWK_CONTEXT_MENU_ITEM_TAG_OTHER, "New Custom Item 3", true, subMenu2);
> 
> Isn't it better to use other action ?

I am fix context menu API tests in this bug https://bugs.webkit.org/show_bug.cgi?id=116601. There I am changing TAG_OTHER to TAG_CUSTOM as TAG_OTHER seems to be some kind of WebKit-GTK specific tag.

[Michal Pakula vel Rutka]

Created attachment 203684 [details]
fixed changelog

[WebKit Commit Bot]

Comment on attachment 203684 [details]
fixed changelog

Clearing flags on attachment: 203684

Committed r151168: <http://trac.webkit.org/changeset/151168>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.