WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
116943
Left arrow on NTP is corrupted
https://bugs.webkit.org/show_bug.cgi?id=116943
Summary
Left arrow on NTP is corrupted
Ryosuke Niwa
Reported
2013-05-29 01:44:14 PDT
We might want to merge
https://chromium.googlesource.com/chromium/blink/+/cbf0eb3458947ff81a836599a692a9c1b32724c3
Now that detecting meta@charset doesn't block processing the resource, we need to be more careful about how we prioritize encodings from meta@charset relative to other mechanisms. Specifically, we meta@charset is supposed to be less important than autodetection from the "<?xml" preamble but more important than encodings detected from sniffing the content itself.
Attachments
Add attachment
proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1
2013-05-29 08:36:45 PDT
We might take the regression test, but the code change is rushed, confusing, and it's just fixing a recent Blink regression anyway.
Alexey Proskuryakov
Comment 2
2013-05-29 08:37:02 PDT
Also, what's "NTP"?
Alexey Proskuryakov
Comment 3
2013-08-09 17:07:01 PDT
Landed the test in <
http://trac.webkit.org/r153916
>.
Adam Barth
Comment 4
2013-08-09 17:44:04 PDT
(In reply to
comment #2
)
> Also, what's "NTP"?
NTP = New Tab Page. It's the page you see in Chrome when you create a new tab. That's just where I noticed the problem, but the probably also occurred on other web sites. You shouldn't need the code change unless you want to try to detect meta@charset without buffering. If you do want to do that, there's another (even uglier) CL that you'd need to merge from later.
Alexey Proskuryakov
Comment 5
2013-08-09 22:30:56 PDT
Thanks Adam!
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug