Bug 116932 - [Qt] Missing files from build after r150853
Summary: [Qt] Missing files from build after r150853
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-29 01:06 PDT by Peter Gal
Modified: 2013-05-29 04:01 PDT (History)
6 users (show)

See Also:

Attachments
speculative fix (1.46 KB, patch)
2013-05-29 01:10 PDT, Peter Gal 		no flags Details | Formatted Diff | Diff
include path fix (981 bytes, patch)
2013-05-29 03:32 PDT, Peter Gal 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Gal 2013-05-29 01:06:23 PDT 
After the r150853 the Qt Mac buildbot gives a little error as stated below: 

../qt-mountainlion-release/build/Source/WebCore/platform/mac/KURLMac.mm:29:9: fatal error: 'CFURLExtras.h' file not found
#import "CFURLExtras.h"
        ^
1 error generated.


The CFURLExtras.{cpp,h} files are missing from the Qt project files.
Comment 1 Peter Gal 2013-05-29 01:10:49 PDT 
Created attachment 203134 [details]
speculative fix
Comment 2 Csaba Osztrogonác 2013-05-29 01:27:31 PDT 
Comment on attachment 203134 [details]
speculative fix

rs=me
Comment 3 WebKit Commit Bot 2013-05-29 01:55:57 PDT 
Comment on attachment 203134 [details]
speculative fix

Clearing flags on attachment: 203134

Committed r150878: <http://trac.webkit.org/changeset/150878>
Comment 4 WebKit Commit Bot 2013-05-29 01:55:58 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Csaba Osztrogonác 2013-05-29 03:11:14 PDT 
Reopen, because it wasn't enough, the build is still failing.
Comment 6 Peter Gal 2013-05-29 03:32:27 PDT 
Created attachment 203147 [details]
include path fix

Forgot the include path.
Comment 7 Csaba Osztrogonác 2013-05-29 03:33:23 PDT 
Comment on attachment 203147 [details]
include path fix

let's go!
Comment 8 WebKit Commit Bot 2013-05-29 04:01:07 PDT 
Comment on attachment 203147 [details]
include path fix

Clearing flags on attachment: 203147

Committed r150882: <http://trac.webkit.org/changeset/150882>
Comment 9 WebKit Commit Bot 2013-05-29 04:01:10 PDT 
All reviewed patches have been landed.  Closing bug.