WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED INVALID
116930
Node::isDescendantOf should be aware of shadow dom tree
https://bugs.webkit.org/show_bug.cgi?id=116930
Summary
Node::isDescendantOf should be aware of shadow dom tree
Ryosuke Niwa
Reported
2013-05-29 00:55:38 PDT
Consider merging
https://chromium.googlesource.com/chromium/blink/+/99c70c6ab825229bff904c9c7b95339cd5c417ac
If a given node is a document node, Node::isDescendantOf should check whether another node is in a shadow tree or not.
Attachments
Add attachment
proposed patch, testcase, etc.
Ahmad Saleem
Comment 1
2022-08-20 04:24:17 PDT
Webkit GitHub Source:
https://github.com/WebKit/WebKit/blob/b528234195932d576b2fe38eef3bdde6a9e7a099/Source/WebCore/dom/Node.cpp#L1025
____ return &treeScope().rootNode() == &other && !isDocumentNode() && isConnected(); ____ Chrome Patch-set modifying to: return document() == other && !isDocumentNode() && inDocument() && !isInShadowTree(); ________
rniwa@webkit.org
- Is this needed anymore? Thanks!
Ryosuke Niwa
Comment 2
2022-08-20 15:27:20 PDT
This is invalid at this point.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug