WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED WONTFIX
116923
Replace reattachIfAttached calls with lazyReattachIfAttached
https://bugs.webkit.org/show_bug.cgi?id=116923
Summary
Replace reattachIfAttached calls with lazyReattachIfAttached
Ryosuke Niwa
Reported
2013-05-29 00:30:03 PDT
Consider merging
https://chromium.googlesource.com/chromium/blink/+/53ff5c99564ef1677df4f3575a206d32557e0eaa
We should always use lazyAttach instead of manually causing reattaches. reattachIfAttached is bad because it encourages manual reattaching instead of letting the next style recalc handle it for you which can result in bad performance. For example setting and unsetting the open attribute on <dialog> elements causes the synchronous destruction and recreation of the entire renderer subtree repeatedly. This change makes sure that we defer all that work until the next style recalc.
Attachments
Add attachment
proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1
2013-05-29 00:58:14 PDT
Also
https://chromium.googlesource.com/chromium/blink/+/d5b57e33ccbf9a89912773d1b12374fbc7f715f8
HTMLSelectElement should use lazyReattach When changing the size attribute on <select> we shouldn't do a sync reattach().
Ahmad Saleem
Comment 2
2022-09-30 18:03:01 PDT
lazyAttach is not something in Webkit. So marking this as "RESOLVED WONTFIX".
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug