Bug 116919 - Fix the firing of m_paintRelatedMilestonesTimer
Summary: Fix the firing of m_paintRelatedMilestonesTimer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-05-29 00:10 PDT by Simon Fraser (smfr)
Modified: 2013-05-29 09:04 PDT (History)
15 users (show)

See Also:

Attachments
Patch (4.97 KB, patch)
2013-05-29 00:16 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (5.78 KB, patch)
2013-05-29 08:55 PDT, Simon Fraser (smfr) 		thorton: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2013-05-29 00:10:34 PDT 
http://trac.webkit.org/changeset/150671 was incorrect, because we haven't actually painted in flushPendingLayerChanges().
Comment 1 Simon Fraser (smfr) 2013-05-29 00:11:15 PDT 
<rdar://problem/14007430>
Comment 2 Simon Fraser (smfr) 2013-05-29 00:16:00 PDT 
Created attachment 203129 [details]
Patch
Comment 3 EFL EWS Bot 2013-05-29 00:22:47 PDT 
Comment on attachment 203129 [details]
Patch

Attachment 203129 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/661101
Comment 4 Early Warning System Bot 2013-05-29 00:24:09 PDT 
Comment on attachment 203129 [details]
Patch

Attachment 203129 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/703219
Comment 5 Early Warning System Bot 2013-05-29 00:25:09 PDT 
Comment on attachment 203129 [details]
Patch

Attachment 203129 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/661100
Comment 6 Build Bot 2013-05-29 00:26:32 PDT 
Comment on attachment 203129 [details]
Patch

Attachment 203129 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/720112
Comment 7 EFL EWS Bot 2013-05-29 00:34:00 PDT 
Comment on attachment 203129 [details]
Patch

Attachment 203129 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/701247
Comment 8 Build Bot 2013-05-29 00:53:10 PDT 
Comment on attachment 203129 [details]
Patch

Attachment 203129 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/723251
Comment 9 kov's GTK+ EWS bot 2013-05-29 02:30:02 PDT 
Comment on attachment 203129 [details]
Patch

Attachment 203129 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/658156
Comment 10 Simon Fraser (smfr) 2013-05-29 08:55:40 PDT 
Created attachment 203204 [details]
Patch
Comment 11 Tim Horton 2013-05-29 08:57:54 PDT 
Comment on attachment 203204 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=203204&action=review

> Source/WebCore/ChangeLog:14
> +        will just dirty CALayers, and layer on Core Animation will ask us to paint them.

layer on?
Comment 12 Simon Fraser (smfr) 2013-05-29 09:04:49 PDT 
https://trac.webkit.org/r150898