We suspend animations going into the page cache and do not resume them coming out. <rdar://problem/14006844>
Created attachment 203115 [details] Patch
Comment on attachment 203115 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=203115&action=review > Source/WebCore/ChangeLog:11 > + was an error in r149576 which was checking a global suspended > + on the AnimationController and not trying to resume anything a global suspended *what*. > Source/WebCore/page/animation/AnimationController.cpp:-315 > - if (!isSuspended()) > - return; How sure are we that there are no cases where this will accidentally get called twice/is there any potential downside to that?
(In reply to comment #2) > (From update of attachment 203115 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=203115&action=review > > > Source/WebCore/ChangeLog:11 > > + was an error in r149576 which was checking a global suspended > > + on the AnimationController and not trying to resume anything > > a global suspended *what*. :) > > > Source/WebCore/page/animation/AnimationController.cpp:-315 > > - if (!isSuspended()) > > - return; > > How sure are we that there are no cases where this will accidentally get called twice/is there any potential downside to that? There is no downside. In fact, the code was originally like this for years, before I added the flag. I just got a bit overzealous when trying to return early.
Committed r150862: <http://trac.webkit.org/changeset/150862>
<rdar://problem/14006844>