This looks like stale code after hitTestResultAtPoint changed signatures and replaced the second boolean parameter with an optional bitfield parameter. AutoscrollController::updateAutoscrollRenderer passes bool true for a parameter that used to mean "allowsShadowDOM", but the parameter is now a bitfield of flags, one of which is AllowsShadowDOM. This could would need to be updated. Or, better yet, if no ports enable PAN_SCROLLING the feature could be removed.
See bug 95720: <http://webkit.org/b/95720> Simplify hitTestResultAtPoint and nodesFromRect APIs
Thanks, that looks like a bit of confusion between two different refactorings.
Created attachment 203853 [details] Patch
Note that allowsShadowDOM is now also implied, and you only need to add a flag to disallow it.
Comment on attachment 203853 [details] Patch I think at the time this was written the signature of hitTestResultAtPoint was: HitTestResult hitTestResultAtPoint(const LayoutPoint&, bool allowShadowContent, bool ignoreClipping = false, HitTestScrollbars scrollbars = DontHitTestScrollbars, HitTestRequest::HitTestRequestType hitType = HitTestRequest::ReadOnly | HitTestRequest::Active, const LayoutSize& padding = LayoutSize()); Current trunk is: HitTestResult hitTestResultAtPoint(const LayoutPoint&, HitTestRequest::HitTestRequestType hitType = HitTestRequest::ReadOnly | HitTestRequest::Active | HitTestRequest::DisallowShadowContent, const LayoutSize& padding = LayoutSize()); So I believe this code intends to have: HitTestRequest::ReadOnly | HitTestRequest::Active (+ allow shadow DOM which is implicit) But your change above ends up with just: HitTestRequest::ReadOnly (+ allow shadow DOM which is implicit) Does this also need to include HitTestRequest::Active?
(In reply to comment #5) > (From update of attachment 203853 [details]) > I think at the time this was written the signature of hitTestResultAtPoint was: > > HitTestResult hitTestResultAtPoint(const LayoutPoint&, bool allowShadowContent, > bool ignoreClipping = false, HitTestScrollbars scrollbars = DontHitTestScrollbars, > HitTestRequest::HitTestRequestType hitType = HitTestRequest::ReadOnly | HitTestRequest::Active, > const LayoutSize& padding = LayoutSize()); > > Current trunk is: > > HitTestResult hitTestResultAtPoint(const LayoutPoint&, > HitTestRequest::HitTestRequestType hitType = HitTestRequest::ReadOnly | HitTestRequest::Active | HitTestRequest::DisallowShadowContent, > const LayoutSize& padding = LayoutSize()); > > So I believe this code intends to have: > > HitTestRequest::ReadOnly | HitTestRequest::Active (+ allow shadow DOM which is implicit) > > But your change above ends up with just: > > HitTestRequest::ReadOnly (+ allow shadow DOM which is implicit) > > Does this also need to include HitTestRequest::Active? To be the same call yes, it shouldn't matter, but I can re-add it to keep the code equivalent.
Created attachment 203932 [details] Patch
Comment on attachment 203932 [details] Patch r=me
Comment on attachment 203932 [details] Patch Clearing flags on attachment: 203932 Committed r151281: <http://trac.webkit.org/changeset/151281>
All reviewed patches have been landed. Closing bug.