Bug 116895 - fast/js/date-DST-time-cusps.html fails after http://trac.webkit.org/changeset/150833
Summary: fast/js/date-DST-time-cusps.html fails after http://trac.webkit.org/changeset...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gavin Barraclough
Keywords: Regression
Depends on:
Reported: 2013-05-28 15:21 PDT by Tim Horton
Modified: 2013-05-30 18:52 PDT (History)
3 users (show)

See Also:

Update results (2.67 KB, patch)
2013-05-28 21:01 PDT, Gavin Barraclough
ap: review+
ap: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2013-05-28 15:21:37 PDT

- PASS Passed all tests (or skipped all tests if your timezone isn't PST/PDT)
+ FAIL 2/4 tests were failed: (new Date(1982, 2, 14, 2, 10)).getHours() should be 1. Was 3., (new Date(1982, 2, 14, 2)).getHours() should be 1. Was 3.
Comment 1 Tim Horton 2013-05-28 15:40:09 PDT
Marked failing in http://trac.webkit.org/changeset/150848.

Please fix by the morning or I'll roll out the offending patch.
Comment 2 Gavin Barraclough 2013-05-28 20:40:51 PDT
This is actually a progression!

Per the description in the test case:
"For times that shouldn't happen we currently go back an hour, but in reality we would like to go forward an hour.  This has been filed as a radar: 4777813"

Now it does!

I'll update the expected results.
Comment 3 Gavin Barraclough 2013-05-28 21:01:40 PDT
Created attachment 203116 [details]
Update results
Comment 4 Alexey Proskuryakov 2013-05-29 22:23:05 PDT
Comment on attachment 203116 [details]
Update results

View in context: https://bugs.webkit.org/attachment.cgi?id=203116&action=review

Looks convincing.

> LayoutTests/ChangeLog:5
> +        <rdar://problem/4777813> Safari incorrectly handles times that shouldn't exist

Also <https://bugs.webkit.org/show_bug.cgi?id=11157>, I guess.

> LayoutTests/ChangeLog:14
> +            - Preffer the latter option for non-existant time (due to clock rolling forwards).

Typo: Preffer. Mistake: existant. Looks suspicious to me: forwards.

> LayoutTests/fast/js/script-tests/date-DST-time-cusps.js:6
>  "For times that happen twice the behavior of all major browsers seems to be to pick the second occurance, i.e. Standard Time not Daylight Time"

Mistake: occurrance.
Comment 5 Gavin Barraclough 2013-05-30 18:52:44 PDT
Fixed in r151000