Blink did this. I agree, we should too. <https://chromium.googlesource.com/chromium/blink/+/6896b8cc83bc337bca452e85b8db0939cc1873ca> > This change removes profiles property from window.console > objec and all related classes. > console.profile/profileEnd can still be used to record > profile but the profiles themselves should be retrieved > only using remote debugging protocol.
<rdar://problem/14004223>
Created attachment 208762 [details] [PATCH] Proposed Fix Remove console.profiles and related code.
Comment on attachment 208762 [details] [PATCH] Proposed Fix Attachment 208762 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1453986 New failing tests: fast/profiler/document-dot-write.html fast/profiler/nested-anonymous-functon.html fast/profiler/anonymous-function-calls-built-in-functions.html fast/profiler/built-in-function-calls-anonymous.html fast/profiler/apply.html fast/profiler/built-in-function-calls-user-defined-function.html fast/profiler/multiple-and-different-scoped-anonymous-function-calls.html http/tests/inspector/inspect-element.html fast/profiler/nested-start-and-stop-profiler.html fast/profiler/execution-context-and-eval-on-same-line.html fast/profiler/multiple-and-different-scoped-function-calls.html fast/profiler/one-execution-context.html fast/profiler/compare-multiple-profiles.html fast/profiler/multiple-anonymous-functions-called-from-the-same-function.html fast/profiler/named-functions-with-display-names.html fast/profiler/no-execution-context.html fast/profiler/inline-event-handler.html fast/profiler/multiple-frames.html fast/profiler/profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting.html fast/profiler/anonymous-functions-with-display-names.html fast/profiler/anonymous-function-calls-eval.html fast/profiler/call.html fast/profiler/profile-with-no-title.html fast/profiler/many-calls-in-the-same-scope.html fast/profiler/calling-the-function-that-started-the-profiler-from-another-scope.html fast/profiler/constructor.html fast/profiler/anonymous-event-handler.html fast/profiler/anonymous-function-called-from-different-contexts.html fast/profiler/event-handler.html fast/profiler/profile-calls-in-included-file.html
Created attachment 208769 [details] Archive of layout-test-results from webkit-ews-07 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-07 Port: mac-mountainlion Platform: Mac OS X 10.8.4
Hmm, it looks like there are a bunch of fast/profiler tests that depend on console.profiles.
Comment on attachment 208762 [details] [PATCH] Proposed Fix Attachment 208762 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1465745 New failing tests: fast/profiler/document-dot-write.html fast/profiler/nested-anonymous-functon.html fast/profiler/anonymous-function-calls-built-in-functions.html fast/profiler/multiple-frames.html fast/profiler/apply.html fast/profiler/built-in-function-calls-user-defined-function.html http/tests/inspector/inspect-element.html fast/profiler/execution-context-and-eval-on-same-line.html fast/profiler/nested-start-and-stop-profiler.html fast/profiler/multiple-and-different-scoped-anonymous-function-calls.html fast/profiler/multiple-and-different-scoped-function-calls.html fast/profiler/one-execution-context.html fast/profiler/compare-multiple-profiles.html editing/pasteboard/copy-image-with-alt-text.html fast/profiler/multiple-anonymous-functions-called-from-the-same-function.html fast/profiler/named-functions-with-display-names.html fast/profiler/no-execution-context.html fast/profiler/inline-event-handler.html fast/profiler/built-in-function-calls-anonymous.html fast/profiler/anonymous-functions-with-display-names.html fast/profiler/anonymous-function-calls-eval.html fast/profiler/call.html fast/profiler/many-calls-in-the-same-scope.html fast/profiler/calling-the-function-that-started-the-profiler-from-another-scope.html fast/profiler/constructor.html fast/profiler/anonymous-event-handler.html fast/profiler/anonymous-function-called-from-different-contexts.html fast/profiler/event-handler.html fast/profiler/profile-calls-in-included-file.html
Created attachment 208936 [details] Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-16 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.4
Moving to the right component.
*** Bug 43471 has been marked as a duplicate of this bug. ***
To keep tests working lets just move it to Internals. I have a patch, seems to work fine.
Created attachment 225204 [details] [PATCH] Proposed Fix Lets see what the bots do. fast/profiler tests pass for me.
Created attachment 225207 [details] [PATCH] For Bots
Landed <http://trac.webkit.org/changeset/164730>.