Bug 116879 - [BlackBerry] Use lazily-backed backingstore tiles
Summary: [BlackBerry] Use lazily-backed backingstore tiles
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jakob Petsovits
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-28 12:22 PDT by Jakob Petsovits
Modified: 2013-05-29 08:36 PDT (History)
5 users (show)

See Also:

Attachments
Patch (5.34 KB, patch)
2013-05-28 12:30 PDT, Jakob Petsovits 		no flags Details | Formatted Diff | Diff
Patch (5.29 KB, patch)
2013-05-29 08:15 PDT, Jakob Petsovits 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jakob Petsovits 2013-05-28 12:22:19 PDT 
Lazy backing has advanced enough to be used for backingstore tiles without drawbacks. Let's switch over to those.
Comment 1 Jakob Petsovits 2013-05-28 12:30:47 PDT 
Created attachment 203077 [details]
Patch
Comment 2 Arvid Nilsson 2013-05-28 12:33:56 PDT 
Comment on attachment 203077 [details]
Patch

LGTM
Comment 3 Mike Lattanzio 2013-05-28 12:37:14 PDT 
Unofficial r+.

Very happy about this.
Comment 4 Carlos Garcia Campos 2013-05-29 00:05:20 PDT 
Comment on attachment 203077 [details]
Patch

Looks great, but the patch doesn't seem to apply upstream.
Comment 5 Jakob Petsovits 2013-05-29 08:15:25 PDT 
Created attachment 203201 [details]
Patch

Thanks Carlos. Apparently the use of BlackBerry::Platform::StringBuilder in AboutData.cpp hasn't made it upstream, that's what caused the conflict. Luckily it's just as easy to delete the same line in the old code, so I'll retain the review and cq+ it right away.
Comment 6 WebKit Commit Bot 2013-05-29 08:36:47 PDT 
Comment on attachment 203201 [details]
Patch

Clearing flags on attachment: 203201

Committed r150896: <http://trac.webkit.org/changeset/150896>
Comment 7 WebKit Commit Bot 2013-05-29 08:36:48 PDT 
All reviewed patches have been landed.  Closing bug.