Bug 116876 - r150199 is very wrong
Summary: r150199 is very wrong
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-28 11:41 PDT by Mark Hahnenberg
Modified: 2013-05-29 15:00 PDT (History)
1 user (show)

See Also:

Attachments
Patch (2.19 KB, patch)
2013-05-28 11:52 PDT, Mark Hahnenberg 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2013-05-28 11:41:20 PDT 
http://trac.webkit.org/changeset/150199 was a result of some mis-read code. We weren't protecting the context, we were protecting the underlying JSValueRef. D'oh!
Comment 1 Mark Hahnenberg 2013-05-28 11:52:36 PDT 
Created attachment 203072 [details]
Patch
Comment 2 Mark Hahnenberg 2013-05-28 14:18:32 PDT 
Committed r150831: <http://trac.webkit.org/changeset/150831>
Comment 3 Mark Hahnenberg 2013-05-28 14:20:48 PDT 
<rdar://problem/14004998>
Comment 4 Geoffrey Garen 2013-05-29 15:00:31 PDT 
Eep!