We should consider merging: https://src.chromium.org/viewvc/blink?view=rev&revision=149314 Apart from fixing the "background-position: 1cm+1cm" case, it has a nice side effect, which is that dramatically reduces the number of shift/reduce conflicts. See http://code.google.com/p/chromium/issues/detail?id=225020 for the original bug report.
Created attachment 203353 [details] Patch
Comment on attachment 203353 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=203353&action=review Looks OK to me. Hope we have sufficient test coverage. I’d like this better if it came with more new tests. > Source/WebCore/css/CSSGrammar.y.in:1817 > - '(' maybe_space calc_func_expr maybe_space ')' maybe_space { > + '(' maybe_space calc_func_expr calc_closing_paren { Seems overkill to have a separate token just for optional space followed by parenthesis; maybe there is some good reason for it, though.
Comment on attachment 203353 [details] Patch Attachment 203353 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/661193 New failing tests: fast/dom/location-new-window-no-crash.html
Created attachment 203365 [details] Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-14 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.3
(In reply to comment #2) > (From update of attachment 203353 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=203353&action=review > > Looks OK to me. Hope we have sufficient test coverage. I’d like this better if it came with more new tests. > > > Source/WebCore/css/CSSGrammar.y.in:1817 > > - '(' maybe_space calc_func_expr maybe_space ')' maybe_space { > > + '(' maybe_space calc_func_expr calc_closing_paren { > > Seems overkill to have a separate token just for optional space followed by parenthesis; maybe there is some good reason for it, though. I think the idea is just to reduce the (apparent) amount of rules as they share the same code.
(In reply to comment #3) > (From update of attachment 203353 [details]) > Attachment 203353 [details] did not pass mac-wk2-ews (mac-wk2): > Output: http://webkit-queues.appspot.com/results/661193 > > New failing tests: > fast/dom/location-new-window-no-crash.html Looks like it isn't related to my changes and this test was already failing in the EWS for some other patches, so I'll likely land this later.
Comment on attachment 203353 [details] Patch Clearing flags on attachment: 203353 Committed r150972: <http://trac.webkit.org/changeset/150972>
All reviewed patches have been landed. Closing bug.