Bug 116861 - Remove XMLMIMETypeRegExp
Summary: Remove XMLMIMETypeRegExp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks: 116791
  Show dependency tree / graph
 
Reported: 2013-05-28 04:01 PDT by Zan Dobersek
Modified: 2013-06-03 14:03 PDT (History)
2 users (show)

See Also:

Attachments
Patch (7.21 KB, patch)
2013-05-28 04:14 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2013-05-28 04:01:25 PDT 
Remove XMLMIMETypeRegExp
Comment 1 Zan Dobersek 2013-05-28 04:14:32 PDT 
Created attachment 203040 [details]
Patch
Comment 2 Alexey Proskuryakov 2013-06-03 10:27:11 PDT 
Comment on attachment 203040 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=203040&action=review

> Source/WebCore/dom/DOMImplementation.cpp:351
> +    size_t slashPosition = mimeType.find('/');

If this was performance sensitive code, it would be better to iterate once, checking for '/' restrictions where "i != slashPosition" check currently is.
Comment 3 Zan Dobersek 2013-06-03 14:03:29 PDT 
Comment on attachment 203040 [details]
Patch

Clearing flags on attachment: 203040

Committed r151126: <http://trac.webkit.org/changeset/151126>
Comment 4 Zan Dobersek 2013-06-03 14:03:35 PDT 
All reviewed patches have been landed.  Closing bug.