Bug 116842 – Move hasNonEmptyBoundingBox from Node to HTMLAnchorElement

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Darin Adler]

Move hasNonEmptyBoundingBox from Node to RenderBoxModelObject

[Darin Adler]

Created attachment 203007 [details]
Patch

[Darin Adler]

Created attachment 203008 [details]
Patch

[Antti Koivisto]

Comment on attachment 203008 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=203008&action=review

> Source/WebCore/ChangeLog:3
> +        Move hasNonEmptyBoundingBox from Node to RenderBoxModelObject

Why there?

> Source/WebCore/html/HTMLAnchorElement.cpp:125
> -    return hasNonEmptyBoundingBox();
> +    RenderBoxModelObject* renderer = renderBoxModelObject();
> +    return renderer && renderer->hasNonEmptyBox();

Unless this is going to have other clients I would just put it to HTMLAnchorElement. No need to bloat RenderBoxModelObject with questionable special case functions like this (any more than Node).

> Source/WebCore/rendering/RenderBoxModelObject.h:178
> +    bool hasNonEmptyBox() const;

isEmpty()?

[Darin Adler]

Comment on attachment 203008 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=203008&action=review

>> Source/WebCore/html/HTMLAnchorElement.cpp:125
>> +    return renderer && renderer->hasNonEmptyBox();
> 
> Unless this is going to have other clients I would just put it to HTMLAnchorElement. No need to bloat RenderBoxModelObject with questionable special case functions like this (any more than Node).

OK.

[Darin Adler]

Created attachment 203015 [details]
Patch

[Antti Koivisto]

Comment on attachment 203015 [details]
Patch

r=me

[Early Warning System Bot]

Comment on attachment 203015 [details]
Patch

Attachment 203015 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/683217

[Early Warning System Bot]

Comment on attachment 203015 [details]
Patch

Attachment 203015 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/683218

[Build Bot]

Comment on attachment 203015 [details]
Patch

Attachment 203015 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/666066

[Darin Adler]

Committed r150783: <http://trac.webkit.org/changeset/150783>

[Lucas Forschler]

Mass move bugs into the DOM component.