Bug 116840 - [BlackBerry] Clear supression flag when caret changes aren't propogated through
Summary: [BlackBerry] Clear supression flag when caret changes aren't propogated through
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nima Ghanavatian
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-27 12:15 PDT by Nima Ghanavatian
Modified: 2013-05-27 14:59 PDT (History)
3 users (show)

See Also:


Attachments
Patch (2.77 KB, patch)
2013-05-27 12:42 PDT, Nima Ghanavatian
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nima Ghanavatian 2013-05-27 12:15:10 PDT
We set and clear the flag upon every use. This leaves us vulnerable if
 1. midway through processing the selection change event is dismissed and
 2. we don't receive a TouchRelease event
One example of this is while dragging the FCC handle we start typing. To
safeguard against this, if the process change guard is set during a
selection change event, we send out to clear the flag status before returning.
Comment 1 Nima Ghanavatian 2013-05-27 12:42:23 PDT
Created attachment 203002 [details]
Patch
Comment 2 Rob Buis 2013-05-27 14:37:26 PDT
Comment on attachment 203002 [details]
Patch

LGTM.
Comment 3 WebKit Commit Bot 2013-05-27 14:59:39 PDT
Comment on attachment 203002 [details]
Patch

Clearing flags on attachment: 203002

Committed r150779: <http://trac.webkit.org/changeset/150779>
Comment 4 WebKit Commit Bot 2013-05-27 14:59:41 PDT
All reviewed patches have been landed.  Closing bug.