WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
116824
[BlackBerry] Move PagePopup implementation to WebKitSupport
https://bugs.webkit.org/show_bug.cgi?id=116824
Summary
[BlackBerry] Move PagePopup implementation to WebKitSupport
Carlos Garcia Campos
Reported
2013-05-27 05:32:05 PDT
After
r150434
PagePopup implementation in BlackBerry port is independent from WebCore. The classes are now in the BlackBerry::WebKit namespace so they can be moved from WEbCoresupport to WebKitSupport. Also, now that the implementation is not shared, it can be simplified a bit more.
Attachments
Patch
(91.08 KB, patch)
2013-05-27 06:02 PDT
,
Carlos Garcia Campos
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1
2013-05-27 06:02:49 PDT
Created
attachment 202977
[details]
Patch
Arvid Nilsson
Comment 2
2013-05-27 07:28:01 PDT
Comment on
attachment 202977
[details]
Patch Looks great!
Rob Buis
Comment 3
2013-05-27 07:51:56 PDT
Comment on
attachment 202977
[details]
Patch Ok.
WebKit Commit Bot
Comment 4
2013-05-27 08:34:59 PDT
Comment on
attachment 202977
[details]
Patch Clearing flags on attachment: 202977 Committed
r150756
: <
http://trac.webkit.org/changeset/150756
>
WebKit Commit Bot
Comment 5
2013-05-27 08:35:01 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug