Bug 116824 - [BlackBerry] Move PagePopup implementation to WebKitSupport
Summary: [BlackBerry] Move PagePopup implementation to WebKitSupport
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-27 05:32 PDT by Carlos Garcia Campos
Modified: 2013-05-27 08:35 PDT (History)
3 users (show)

See Also:


Attachments
Patch (91.08 KB, patch)
2013-05-27 06:02 PDT, Carlos Garcia Campos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2013-05-27 05:32:05 PDT
After r150434 PagePopup implementation in BlackBerry port is independent from WebCore. The classes are now in the BlackBerry::WebKit namespace so they can be moved from WEbCoresupport to WebKitSupport. Also, now that the implementation is not shared, it can be simplified a bit more.
Comment 1 Carlos Garcia Campos 2013-05-27 06:02:49 PDT
Created attachment 202977 [details]
Patch
Comment 2 Arvid Nilsson 2013-05-27 07:28:01 PDT
Comment on attachment 202977 [details]
Patch

Looks great!
Comment 3 Rob Buis 2013-05-27 07:51:56 PDT
Comment on attachment 202977 [details]
Patch

Ok.
Comment 4 WebKit Commit Bot 2013-05-27 08:34:59 PDT
Comment on attachment 202977 [details]
Patch

Clearing flags on attachment: 202977

Committed r150756: <http://trac.webkit.org/changeset/150756>
Comment 5 WebKit Commit Bot 2013-05-27 08:35:01 PDT
All reviewed patches have been landed.  Closing bug.