Bug 116811 - Add a balanced benchmark for QuerySelector
Summary: Add a balanced benchmark for QuerySelector
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-27 01:52 PDT by Benjamin Poulain
Modified: 2013-05-27 15:30 PDT (History)
1 user (show)

See Also:


Attachments
Patch (16.73 KB, patch)
2013-05-27 02:04 PDT, Benjamin Poulain
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2013-05-27 01:52:07 PDT
Add a balanced benchmark for QuerySelector
Comment 1 Benjamin Poulain 2013-05-27 02:04:40 PDT
Created attachment 202955 [details]
Patch
Comment 2 Benjamin Poulain 2013-05-27 02:07:49 PDT
I get 0.59% when run with run-pert-tests. 1.2% when run in Safari.

By the way, there are other weird tests for query selectors. And they are in Parser/ for some reason.
Comment 3 Ryosuke Niwa 2013-05-27 13:51:56 PDT
Comment on attachment 202955 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=202955&action=review

> PerformanceTests/ChangeLog:18
> +        * DOM/QuerySelector.html: Added.
> +        * DOM/resources/query-selector.html: Added.

We shouldn't be adding new tests to DOM for now since they're tests imported from chromium's dom_perf test.
They are two tests misplaced there but...
Comment 4 Benjamin Poulain 2013-05-27 14:09:14 PDT
> > PerformanceTests/ChangeLog:18
> > +        * DOM/QuerySelector.html: Added.
> > +        * DOM/resources/query-selector.html: Added.
> 
> We shouldn't be adding new tests to DOM for now since they're tests imported from chromium's dom_perf test.
> They are two tests misplaced there but...

Okay, that explain why the others are in Parser/.
Any suggestion where to put this test?
Comment 5 Ryosuke Niwa 2013-05-27 14:51:20 PDT
(In reply to comment #4)
>
> Okay, that explain why the others are in Parser/.
> Any suggestion where to put this test?

CSS?
Comment 6 Benjamin Poulain 2013-05-27 15:30:55 PDT
Committed r150781: <http://trac.webkit.org/changeset/150781>