Bug 116808 - [EFL][GTK] fast/regions/offsetLeft-offsetTop-in-multiple-regions.html is failing
Summary: [EFL][GTK] fast/regions/offsetLeft-offsetTop-in-multiple-regions.html is failing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk, LayoutTestFailure
Depends on:
Blocks:
 
Reported: 2013-05-27 01:11 PDT by Zan Dobersek
Modified: 2013-05-27 08:21 PDT (History)
5 users (show)

See Also:


Attachments
Patch (3.52 KB, patch)
2013-05-27 04:08 PDT, Radu Stavila
no flags Details | Formatted Diff | Diff
Patch (3.60 KB, patch)
2013-05-27 04:19 PDT, Radu Stavila
no flags Details | Formatted Diff | Diff
Patch (3.60 KB, patch)
2013-05-27 05:58 PDT, Radu Stavila
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2013-05-27 01:11:50 PDT
The fast/regions/offsetLeft-offsetTop-in-multiple-regions.html layout test is failing on EFL and GTK since introduced in r150383.
http://trac.webkit.org/changeset/150383
http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fregions%2FoffsetLeft-offsetTop-in-multiple-regions.html

The test was failing in additional ways on these two platforms until r150458, much like the Qt port. That revision fixed those issues, making the test pass completely on Qt but still failing on EFL and GTK.
http://trac.webkit.org/changeset/150458

Here's the remaining failure on GTK and EFL platforms. They both enable the subpixel layout.

--- /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/fast/regions/offsetLeft-offsetTop-in-multiple-regions-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/fast/regions/offsetLeft-offsetTop-in-multiple-regions-actual.txt
@@ -19,7 +19,7 @@
 PASS span.offsetTop is 610
 PASS image.offsetParent is document.body
 PASS image.offsetLeft is 650
-PASS image.offsetTop is 630
+FAIL image.offsetTop should be 630. Was 629.
 PASS successfullyParsed is true
 
 TEST COMPLETE
Comment 1 Radu Stavila 2013-05-27 04:08:37 PDT
Created attachment 202965 [details]
Patch
Comment 2 Mihnea Ovidenie 2013-05-27 04:15:42 PDT
(In reply to comment #1)
> Created an attachment (id=202965) [details]
> Patch

Please explain in the Changelog why the test was failing :)
Comment 3 Radu Stavila 2013-05-27 04:19:11 PDT
Created attachment 202968 [details]
Patch
Comment 4 Radu Stavila 2013-05-27 05:58:23 PDT
Created attachment 202976 [details]
Patch
Comment 5 WebKit Commit Bot 2013-05-27 08:21:03 PDT
Comment on attachment 202976 [details]
Patch

Clearing flags on attachment: 202976

Committed r150755: <http://trac.webkit.org/changeset/150755>
Comment 6 WebKit Commit Bot 2013-05-27 08:21:05 PDT
All reviewed patches have been landed.  Closing bug.