Bug 116799 - Plugins with no src but valid type should not snapshot
Summary: Plugins with no src but valid type should not snapshot
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-26 16:11 PDT by Dean Jackson
Modified: 2013-05-26 18:46 PDT (History)
4 users (show)

See Also:

Attachments
Patch (3.09 KB, patch)
2013-05-26 16:15 PDT, Dean Jackson 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2013-05-26 16:11:49 PDT 
There are a few plugins in the wild that don't take any src attribute - they simply load the plugin from the mime type. Google Hangouts is an example.
Comment 1 Dean Jackson 2013-05-26 16:15:27 PDT 
Created attachment 202933 [details]
Patch
Comment 2 Dean Jackson 2013-05-26 16:19:32 PDT 
<rdar://problem/13695911>
Comment 3 Darin Adler 2013-05-26 18:02:58 PDT 
Comment on attachment 202933 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=202933&action=review

> Source/WebCore/html/HTMLPlugInImageElement.cpp:649
> +    if ((m_loadedUrl.isNull() || m_loadedUrl.isEmpty()) && !loadedMimeType().isEmpty()) {

No need to write (m_loadedUrl.isNull() || m_loadedUrl.isEmpty()); that’s the same as m_loadedUrl.isEmpty().
Comment 4 Dean Jackson 2013-05-26 18:46:03 PDT 
Committed r150731: <http://trac.webkit.org/changeset/150731>