Bug 116797 - Rename FontFallbackList to FontGlyphs
Summary: Rename FontFallbackList to FontGlyphs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-26 15:48 PDT by Antti Koivisto
Modified: 2013-05-27 02:01 PDT (History)
9 users (show)

See Also:


Attachments
patch (21.66 KB, patch)
2013-05-26 16:02 PDT, Antti Koivisto
kling: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2013-05-26 15:48:37 PDT
Maybe it was a fallback list once. Nowadays its purpose is to cache realized glyphs and related data.
Comment 1 Antti Koivisto 2013-05-26 16:02:02 PDT
Created attachment 202931 [details]
patch
Comment 2 Andreas Kling 2013-05-26 16:08:07 PDT
Comment on attachment 202931 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=202931&action=review

r=me, go go Antti go!

> Source/WebCore/platform/graphics/FontFallbackList.cpp:2
> - * Copyright (C) 2006 Apple Computer, Inc.  All rights reserved.
> + * Copyright (C) 2006, 2013 Apple Computer, Inc.  All rights reserved.

:D
Comment 3 Antti Koivisto 2013-05-26 16:42:49 PDT
http://trac.webkit.org/changeset/150727
Comment 4 mitz 2013-05-26 18:38:25 PDT
(In reply to comment #0)
> Maybe it was a fallback list once. Nowadays its purpose is to cache realized glyphs and related data.

I don’t think that’s a good characterization. This object caches realized FontData objects—which are used to key into the glyph cache—but I wouldn’t call them “glyphs and related data”. Even the accessors on this class return FontData instances!
Comment 5 Antti Koivisto 2013-05-27 02:01:40 PDT
(In reply to comment #4)
> (In reply to comment #0)
> > Maybe it was a fallback list once. Nowadays its purpose is to cache realized glyphs and related data.
> 
> I don’t think that’s a good characterization. This object caches realized FontData objects—which are used to key into the glyph cache—but I wouldn’t call them “glyphs and related data”. Even the accessors on this class return FontData instances!

Suggestion welcome!

Note that the encapsulation and code moving in bug 116803 gave FontGlyphs a glyph API, significantly reducing need for direct FontData access. Also the vaguely named (Simple)FontData type is in fact largely about providing glyphs and information about glyphs.