Bug 116778 - Move Node::supportsFocus() to Element.
Summary: Move Node::supportsFocus() to Element.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-25 22:39 PDT by Andreas Kling
Modified: 2013-05-26 02:39 PDT (History)
3 users (show)

See Also:


Attachments
Patch (18.98 KB, patch)
2013-05-25 22:39 PDT, Andreas Kling
no flags Details | Formatted Diff | Diff
Patch (18.98 KB, patch)
2013-05-25 22:57 PDT, Andreas Kling
koivisto: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-05-25 22:39:03 PDT
Move Node::supportsFocus() to Element.
Comment 1 Andreas Kling 2013-05-25 22:39:42 PDT
Created attachment 202905 [details]
Patch
Comment 2 WebKit Commit Bot 2013-05-25 22:45:05 PDT
Attachment 202905 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/accessibility/AccessibilityNodeObject.cpp', u'Source/WebCore/dom/Element.h', u'Source/WebCore/dom/Node.cpp', u'Source/WebCore/dom/Node.h', u'Source/WebCore/html/HTMLAnchorElement.h', u'Source/WebCore/html/HTMLAreaElement.h', u'Source/WebCore/html/HTMLBodyElement.h', u'Source/WebCore/html/HTMLElement.h', u'Source/WebCore/html/HTMLFieldSetElement.h', u'Source/WebCore/html/HTMLFormControlElement.h', u'Source/WebCore/html/HTMLFrameElementBase.h', u'Source/WebCore/html/HTMLMediaElement.h', u'Source/WebCore/html/HTMLOptGroupElement.h', u'Source/WebCore/html/HTMLOptionElement.h', u'Source/WebCore/html/HTMLOutputElement.h', u'Source/WebCore/svg/SVGAElement.h', u'Source/WebCore/svg/SVGCircleElement.h', u'Source/WebCore/svg/SVGEllipseElement.h', u'Source/WebCore/svg/SVGGElement.h', u'Source/WebCore/svg/SVGImageElement.h', u'Source/WebCore/svg/SVGLineElement.h', u'Source/WebCore/svg/SVGPathElement.h', u'Source/WebCore/svg/SVGPolyElement.h', u'Source/WebCore/svg/SVGRectElement.h', u'Source/WebCore/svg/SVGSVGElement.h', u'Source/WebCore/svg/SVGSwitchElement.h', u'Source/WebCore/svg/SVGSymbolElement.h', u'Source/WebCore/svg/SVGTextElement.h', u'Source/WebCore/svg/SVGUseElement.h']" exit_code: 1
Source/WebCore/ChangeLog:3:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 28 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Andreas Kling 2013-05-25 22:57:10 PDT
Created attachment 202906 [details]
Patch
Comment 4 Andreas Kling 2013-05-26 02:39:37 PDT
Committed r150710: <http://trac.webkit.org/changeset/150710>