Bug 116756 - AX: WKView is unable to set AXFocused to YES and does not handle keyboard events as expected
Summary: AX: WKView is unable to set AXFocused to YES and does not handle keyboard eve...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: chris fleizach
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-05-24 22:40 PDT by chris fleizach
Modified: 2013-05-28 14:47 PDT (History)
7 users (show)

See Also:


Attachments
patch (2.62 KB, patch)
2013-05-24 22:45 PDT, chris fleizach
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description chris fleizach 2013-05-24 22:40:06 PDT
It appears that if AXFocused is set to YES on a web view that accepts text editing, the WebView does not become the first responder
Comment 1 chris fleizach 2013-05-24 22:45:37 PDT
Created attachment 202875 [details]
patch
Comment 2 chris fleizach 2013-05-24 22:46:37 PDT
rdar://13925131
Comment 3 Tim Horton 2013-05-28 14:10:07 PDT
Comment on attachment 202875 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=202875&action=review

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:3051
> +        bool focus = [number intValue] != 0;

NSNumber has boolValue...

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:3058
> +                page->chrome().client()->focus();

Could grab the chrome client in a local and reuse it on these three lines.
Comment 4 chris fleizach 2013-05-28 14:47:57 PDT
http://trac.webkit.org/changeset/150836