Bug 116755 - CSSParser::parseImageResolution doesn't need a parameter.
Summary: CSSParser::parseImageResolution doesn't need a parameter.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-24 21:01 PDT by Jaehun Lim
Modified: 2013-05-26 19:32 PDT (History)
6 users (show)

See Also:


Attachments
Patch (2.62 KB, patch)
2013-05-24 21:36 PDT, Jaehun Lim
no flags Details | Formatted Diff | Diff
Patch (2.72 KB, patch)
2013-05-26 18:11 PDT, Jaehun Lim
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jaehun Lim 2013-05-24 21:01:53 PDT
parseImageResolution() can get CSSPraserValueList from m_valueList directly.
Comment 1 Jaehun Lim 2013-05-24 21:36:41 PDT
Created attachment 202874 [details]
Patch
Comment 2 Darin Adler 2013-05-26 17:44:49 PDT
Comment on attachment 202874 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=202874&action=review

> Source/WebCore/css/CSSParser.cpp:2983
>          m_valueList->next();

This line of code does not seem necessary. The parseImageResolution function already kept calling next() until it returned 0. This line of code does nothing.
Comment 3 Jaehun Lim 2013-05-26 18:09:05 PDT
Comment on attachment 202874 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=202874&action=review

>> Source/WebCore/css/CSSParser.cpp:2983
>>          m_valueList->next();
> 
> This line of code does not seem necessary. The parseImageResolution function already kept calling next() until it returned 0. This line of code does nothing.

Yes.
I think "if (!parsedValue) / return false;" are redundant, too. parsedValue will be checked after switch case statement.
I'll remove these two lines.
Comment 4 Jaehun Lim 2013-05-26 18:11:32 PDT
Created attachment 202941 [details]
Patch
Comment 5 WebKit Commit Bot 2013-05-26 19:32:52 PDT
Comment on attachment 202941 [details]
Patch

Clearing flags on attachment: 202941

Committed r150734: <http://trac.webkit.org/changeset/150734>
Comment 6 WebKit Commit Bot 2013-05-26 19:32:55 PDT
All reviewed patches have been landed.  Closing bug.