Bug 116746 – Move history property list writer to WebKit

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Anders Carlsson]

Move history property list writer to WebKit

[Anders Carlsson]

Created attachment 202864 [details]
Patch

[WebKit Commit Bot]

Attachment 202864 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/history/cf/HistoryPropertyList.cpp', u'Source/WebCore/history/cf/HistoryPropertyList.h', u'Source/WebCore/platform/cf/BinaryPropertyList.cpp', u'Source/WebCore/platform/cf/BinaryPropertyList.h', u'Source/WebKit/ChangeLog', u'Source/WebKit/WebKit.xcodeproj/project.pbxproj', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/History/BinaryPropertyList.cpp', u'Source/WebKit/mac/History/BinaryPropertyList.h', u'Source/WebKit/mac/History/HistoryPropertyList.cpp', u'Source/WebKit/mac/History/HistoryPropertyList.h', u'Source/WebKit/mac/History/WebHistory.mm']" exit_code: 1
Source/WebKit/mac/History/BinaryPropertyList.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Source/WebKit/mac/History/HistoryPropertyList.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 2 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Tim Horton]

Comment on attachment 202864 [details]
Patch

I assume you'll do The Right Thing when moving the files.

[Anders Carlsson]

Committed r150665: <http://trac.webkit.org/changeset/150665>

[Alexey Proskuryakov]

This patch does not have a rationale posted.

Why is this helpful? I thought we wanted to move everything in the opposite direction, making WebKit a thin layer for platform specific APIs.

[Anders Carlsson]

(In reply to comment #5)
> This patch does not have a rationale posted.
> 
> Why is this helpful? I thought we wanted to move everything in the opposite direction, making WebKit a thin layer for platform specific APIs.

It’s moving code that was only used by WebKit/mac away from WebCore.

[Alexey Proskuryakov]

Sure, that's what the patch did, I can see that.

What is the rationale? Previously, we never intended to make WebCore lean and mean by making WebKit fat.