Bug 116737 - Make team.html have each contributor's area of expertise
Summary: Make team.html have each contributor's area of expertise
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Bem Jones-Bey
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-24 14:04 PDT by Bem Jones-Bey
Modified: 2013-05-24 15:34 PDT (History)
3 users (show)

See Also:


Attachments
Patch (145.96 KB, patch)
2013-05-24 14:08 PDT, Bem Jones-Bey
benjamin: review+
Details | Formatted Diff | Diff
Patch (146.02 KB, patch)
2013-05-24 14:48 PDT, Bem Jones-Bey
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Bem Jones-Bey 2013-05-24 14:04:36 PDT
Make team.html have each contributor's area of expertise
Comment 1 Bem Jones-Bey 2013-05-24 14:08:01 PDT
Created attachment 202848 [details]
Patch

Add an expertise field and update team.html to read it
Comment 2 Ryosuke Niwa 2013-05-24 14:30:25 PDT
Comment on attachment 202848 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=202848&action=review

> Tools/ChangeLog:13
> +        Changed formatting of the file because the lines are getting way to
> +        long, and I generated this, so it's easier if the formatting of the
> +        file is regular.

Please either revert this change or do it in a separate patch.
Comment 3 Benjamin Poulain 2013-05-24 14:31:29 PDT
Comment on attachment 202848 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=202848&action=review

LGTM :)

Can you please double check the unicode name before cq+?

> Tools/Scripts/webkitpy/common/config/contributors.json:85
> +      "Alexander Færøy" : {

Shouldn't this be u"Ale..."?
Comment 4 Bem Jones-Bey 2013-05-24 14:47:16 PDT
(In reply to comment #3)
> (From update of attachment 202848 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=202848&action=review
> 
> LGTM :)

Hah!

> 
> Can you please double check the unicode name before cq+?
> 
> > Tools/Scripts/webkitpy/common/config/contributors.json:85
> > +      "Alexander Færøy" : {
> 
> Shouldn't this be u"Ale..."?

Looks like the utf-8 got messed up in the upload somewhere. I'll change them to be \u escapes.
Comment 5 Bem Jones-Bey 2013-05-24 14:48:34 PDT
Created attachment 202853 [details]
Patch

Update to use escapes for unicode instead of utf-8, like the original contributors.json did
Comment 6 WebKit Commit Bot 2013-05-24 15:34:32 PDT
Comment on attachment 202853 [details]
Patch

Clearing flags on attachment: 202853

Committed r150662: <http://trac.webkit.org/changeset/150662>
Comment 7 WebKit Commit Bot 2013-05-24 15:34:34 PDT
All reviewed patches have been landed.  Closing bug.