Bug 116734 - [CSS Shapes] Fix style issues in BasicShapes
Summary: [CSS Shapes] Fix style issues in BasicShapes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Bem Jones-Bey
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-24 12:16 PDT by Bem Jones-Bey
Modified: 2013-05-29 11:49 PDT (History)
5 users (show)

See Also:

Attachments
Patch (24.31 KB, patch)
2013-05-29 10:48 PDT, Bem Jones-Bey 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bem Jones-Bey 2013-05-24 12:16:18 PDT 
The following BasicShape files have a number of style issues that make it hard to edit the files and keep them consistent. I would like to fix them.

Source/WebCore/rendering/style/BasicShapes.cpp: indentation is wrong for some of the lines, they're lined up with method/function calls, which causes the number of spaces  to not be a multiple of 4 on those lines.
Source/WebCore/css/CSSBasicShapes.h: the enum members are NAMED_LIKE_THIS but the style guide says they should be NamedLikeThis.
Source/WebCore/rendering/style/BasicShapes.h: the enum members are NAMED_LIKE_THIS but the style guide says they should be NamedLikeThis.
Comment 1 Bem Jones-Bey 2013-05-29 10:48:02 PDT 
Created attachment 203216 [details]
Patch

Fix style issues.
Comment 2 Alexandru Chiculita 2013-05-29 11:08:08 PDT 
Comment on attachment 203216 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2013-05-29 11:49:33 PDT 
Comment on attachment 203216 [details]
Patch

Clearing flags on attachment: 203216

Committed r150917: <http://trac.webkit.org/changeset/150917>
Comment 4 WebKit Commit Bot 2013-05-29 11:49:34 PDT 
All reviewed patches have been landed.  Closing bug.