Current version of ATK in efl-ews environment is 2.4.0 and is taken from the platform (it is not listed in jhbuild moduleset). That version is old-ish and contain deprecated symbols and missing API, that are blocking patches in other ports (gtk). This bug is for bumping ATK version to 2.8.0 in efl-ews. That version is the same gtk port uses. See bug https://bugs.webkit.org/show_bug.cgi?id=115647 for more details on why this is needed.
Created attachment 202832 [details] add ATK 2.8.0 to efl jhbuild moduleset
Adding Gyuyoung Kim to CC. Please, any comment on this one? Thanks!
Comment on attachment 202832 [details] add ATK 2.8.0 to efl jhbuild moduleset Looks fine but you probably need to bump the version in Cmake as well (likely in OptionsEfl.cmake).
Comment on attachment 202832 [details] add ATK 2.8.0 to efl jhbuild moduleset I think we need to keep needed pkg in jhbuild. If not, build time will be increased. However, it looks this patch was already added to gtk port. To be sync with gtk port, r=me. FYI, EFL EWS and buildbots start to run on Ubuntu 13.04.
(In reply to comment #3) > (From update of attachment 202832 [details]) > Looks fine but you probably need to bump the version in Cmake as well (likely in OptionsEfl.cmake). Yes, it would be good if you add a checking condition in OptionEfl.cmake before landing as Christophe said.
Created attachment 202982 [details] add ATK 2.8.0 to efl jhbuild moduleset and corresponding CMake checks Thanks for the feedback, folks! I have updated the patch, bumping required version of ATK to 2.8.0 in CMake files as well.
(In reply to comment #6) > Created an attachment (id=202982) [details] > add ATK 2.8.0 to efl jhbuild moduleset and corresponding CMake checks > any comment on this one?
Comment on attachment 202982 [details] add ATK 2.8.0 to efl jhbuild moduleset and corresponding CMake checks View in context: https://bugs.webkit.org/attachment.cgi?id=202982&action=review > Source/cmake/FindATK.cmake:48 > + VERSION_VAR PC_ATK_VERSION) Looks need to keep indentation.
*** Bug 117134 has been marked as a duplicate of this bug. ***
Created attachment 203614 [details] last patch with indentation fixed Now indentation in Source/cmake/FindATK.cmake is similar to others (i.e, FindLibSoup.cmake)
Comment on attachment 203614 [details] last patch with indentation fixed FYI, you don't need to re-request r? again if reviewer already set r+.
Comment on attachment 203614 [details] last patch with indentation fixed Clearing flags on attachment: 203614 Committed r151145: <http://trac.webkit.org/changeset/151145>
All reviewed patches have been landed. Closing bug.