Bug 116716 - [sh4] Optimize LLINT generated code and few bug fixes in baseline JIT
Summary: [sh4] Optimize LLINT generated code and few bug fixes in baseline JIT
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-24 03:32 PDT by Julien Brianceau
Modified: 2013-05-24 09:45 PDT (History)
5 users (show)

See Also:


Attachments
SH4 LLINT optimizations and fix few bugs in baseline JIT (12.69 KB, patch)
2013-05-24 03:34 PDT, Julien Brianceau
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Brianceau 2013-05-24 03:32:19 PDT
Optimize LLINT generated code for sh4 backend and fix few bugs in sh4 baseline JIT.
Comment 1 Julien Brianceau 2013-05-24 03:34:49 PDT
Created attachment 202799 [details]
SH4 LLINT optimizations and fix few bugs in baseline JIT
Comment 2 Julien Brianceau 2013-05-24 05:36:57 PDT
I've tested this patch on r150629 and I didn't see regressions when running
- Tools/Scripts/run-javascriptcore-tests
- Tools/Scripts/run-fast-jsc
- SunSpider 1.0


SunSpider 1.0 results for r150629 without patch:
============================================
RESULTS (means and 95% confidence intervals)
--------------------------------------------
Total:                 13334.4ms +/- 0.3%
--------------------------------------------

  3d:                   2666.0ms +/- 0.3%
    cube:                827.0ms +/- 0.6%
    morph:               450.3ms +/- 0.9%
    raytrace:           1388.8ms +/- 0.3%

  access:               1977.4ms +/- 1.3%
    binary-trees:        138.1ms +/- 0.7%
    fannkuch:           1193.5ms +/- 2.4%
    nbody:               464.9ms +/- 1.2%
    nsieve:              180.9ms +/- 1.4%

  bitops:               1058.3ms +/- 0.3%
    3bit-bits-in-byte:    94.3ms +/- 2.1%
    bits-in-byte:        121.8ms +/- 0.3%
    bitwise-and:         202.1ms +/- 0.1%
    nsieve-bits:         640.1ms +/- 0.4%

  controlflow:           103.3ms +/- 0.4%
    recursive:           103.3ms +/- 0.4%

  crypto:               1156.4ms +/- 0.2%
    aes:                 663.8ms +/- 0.5%
    md5:                 315.8ms +/- 0.9%
    sha1:                176.9ms +/- 0.4%

  date:                 2085.5ms +/- 0.6%
    format-tofte:        942.9ms +/- 0.4%
    format-xparb:       1142.6ms +/- 1.1%

  math:                  990.9ms +/- 1.3%
    cordic:              289.8ms +/- 0.9%
    partial-sums:        414.6ms +/- 3.1%
    spectral-norm:       286.5ms +/- 0.9%

  regexp:                533.1ms +/- 0.5%
    dna:                 533.1ms +/- 0.5%

  string:               2763.6ms +/- 0.5%
    base64:              227.9ms +/- 1.9%
    fasta:               423.1ms +/- 0.7%
    tagcloud:            593.1ms +/- 0.8%
    unpack-code:        1186.6ms +/- 0.9%
    validate-input:      332.9ms +/- 1.0%



SunSpider 1.0 results for r150629 with patch:
============================================
RESULTS (means and 95% confidence intervals)
--------------------------------------------
Total:                 12966.6ms +/- 0.3%
--------------------------------------------

  3d:                   2606.0ms +/- 0.7%
    cube:                816.5ms +/- 0.3%
    morph:               453.6ms +/- 0.5%
    raytrace:           1335.9ms +/- 1.4%

  access:               1945.9ms +/- 0.4%
    binary-trees:        122.9ms +/- 1.5%
    fannkuch:           1183.3ms +/- 0.8%
    nbody:               456.1ms +/- 0.4%
    nsieve:              183.6ms +/- 0.9%

  bitops:               1036.0ms +/- 0.3%
    3bit-bits-in-byte:    79.5ms +/- 0.6%
    bits-in-byte:        111.9ms +/- 1.6%
    bitwise-and:         201.0ms +/- 0.0%
    nsieve-bits:         643.6ms +/- 0.5%

  controlflow:            74.8ms +/- 1.0%
    recursive:            74.8ms +/- 1.0%

  crypto:               1156.6ms +/- 0.6%
    aes:                 685.5ms +/- 0.4%
    md5:                 299.9ms +/- 1.9%
    sha1:                171.3ms +/- 4.5%

  date:                 1985.1ms +/- 0.7%
    format-tofte:        913.5ms +/- 0.6%
    format-xparb:       1071.6ms +/- 1.3%

  math:                  891.5ms +/- 1.4%
    cordic:              272.0ms +/- 0.9%
    partial-sums:        354.1ms +/- 3.4%
    spectral-norm:       265.4ms +/- 0.4%

  regexp:                533.4ms +/- 0.4%
    dna:                 533.4ms +/- 0.4%

  string:               2737.4ms +/- 1.0%
    base64:              220.4ms +/- 3.0%
    fasta:               440.8ms +/- 5.9%
    tagcloud:            553.8ms +/- 2.0%
    unpack-code:        1178.4ms +/- 0.9%
    validate-input:      344.1ms +/- 2.2%
Comment 3 Geoffrey Garen 2013-05-24 09:23:10 PDT
Comment on attachment 202799 [details]
SH4 LLINT optimizations and fix few bugs in baseline JIT

r=me
Comment 4 WebKit Commit Bot 2013-05-24 09:45:52 PDT
Comment on attachment 202799 [details]
SH4 LLINT optimizations and fix few bugs in baseline JIT

Clearing flags on attachment: 202799

Committed r150644: <http://trac.webkit.org/changeset/150644>
Comment 5 WebKit Commit Bot 2013-05-24 09:45:54 PDT
All reviewed patches have been landed.  Closing bug.