Bug 116714 – [WK2][GTK] Use GtkWindow::is-active to set WindowIsActive flag in WebViewBase

• Status: NEW
• Component: New Bugs

[Claudio Saavedra]

[WK2][GTK] Use GtkWindow::is-active to set WindowIsActive flag in WebViewBase

[Claudio Saavedra]

Created attachment 202794 [details]
Patch

[Claudio Saavedra]

Comment on attachment 202794 [details]
Patch

Something is wrong with the patch, should have tested it first.

[Claudio Saavedra]

Created attachment 203010 [details]
Patch

[WebKit Commit Bot]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[WebKit Commit Bot]

Attachment 203010 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp']" exit_code: 1
Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:201:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Carlos Garcia Campos]

Comment on attachment 203010 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=203010&action=review

I wonder if we still need the hack when the toplevel is a popup and the focus has been set programatically by WTR. Did you run the tests?

> Source/WebKit2/ChangeLog:7
> +

You should explain here the changes, why are they needed? what bug does this fix exactly? What's the new behaviour? what's broken before? etc.

> Source/WebKit2/ChangeLog:12
> +        GtkWindow::is-toplevel instead of focus-in/out to set the

is-toplevel? I guess you mean is-active

> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:116
> +    unsigned long toplevelIsActiveID;

Nit: I would use toplevelNotifyIsActiveID to make a bit clearer this is the ID of a signal handler.

> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:167
> +static void toplevelWindowNotifyIsActive(GtkWindow* window, GParamSpec* pspec, WebKitWebViewBase* webViewBase)

Remove the names of unused parameters (pspec).

> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:170
> +    priv->isInWindowActive = gtk_window_is_active(window);

Do we still need to cache the value? or can we use gtk_window_is_active(window) directly when needed?