Bug 116707 - [EFL][WK2] Remove unneeded WebCore namespace use in ewk
Summary: [EFL][WK2] Remove unneeded WebCore namespace use in ewk
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-24 00:31 PDT by Gyuyoung Kim
Modified: 2013-05-27 23:48 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.81 KB, patch)
2013-05-24 00:32 PDT, Gyuyoung Kim
no flags Details | Formatted Diff | Diff
Patch (1.87 KB, patch)
2013-05-24 00:40 PDT, Gyuyoung Kim
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2013-05-24 00:31:10 PDT
SSIA
Comment 1 Gyuyoung Kim 2013-05-24 00:32:19 PDT
Created attachment 202778 [details]
Patch
Comment 2 Chris Dumez 2013-05-24 00:36:44 PDT
Comment on attachment 202778 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=202778&action=review

> Source/WebKit2/UIProcess/API/efl/ewk_security_origin.cpp:33
>  #include <WebCore/SecurityOrigin.h>

Could we remove this header include as well?
Comment 3 Gyuyoung Kim 2013-05-24 00:40:35 PDT
Created attachment 202779 [details]
Patch
Comment 4 Gyuyoung Kim 2013-05-24 00:40:56 PDT
(In reply to comment #2)
> (From update of attachment 202778 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=202778&action=review
> 
> > Source/WebKit2/UIProcess/API/efl/ewk_security_origin.cpp:33
> >  #include <WebCore/SecurityOrigin.h>
> 
> Could we remove this header include as well?

Sure !
Comment 5 Gyuyoung Kim 2013-05-24 00:43:26 PDT
(In reply to comment #4)
> (In reply to comment #2)
> > (From update of attachment 202778 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=202778&action=review
> > 
> > > Source/WebKit2/UIProcess/API/efl/ewk_security_origin.cpp:33
> > >  #include <WebCore/SecurityOrigin.h>
> > 
> > Could we remove this header include as well?
> 
> Sure !

Oops. EFL WK2 EWS is pending now. There was no problem when I remove it on my local source.
Comment 6 Chris Dumez 2013-05-24 00:52:18 PDT
Comment on attachment 202779 [details]
Patch

Looks fine, r=me. Please make sure it builds locally before landing as the ews is sluggish today.
Comment 7 Gyuyoung Kim 2013-05-27 23:48:13 PDT
Comment on attachment 202779 [details]
Patch

Clearing flags on attachment: 202779

Committed r150787: <http://trac.webkit.org/changeset/150787>
Comment 8 Gyuyoung Kim 2013-05-27 23:48:20 PDT
All reviewed patches have been landed.  Closing bug.