Bug 116690 - Don't run all plug-ins unsandboxed
Summary: Don't run all plug-ins unsandboxed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on: 116699
Blocks:
  Show dependency treegraph
 
Reported: 2013-05-23 13:43 PDT by Anders Carlsson
Modified: 2013-05-23 22:02 PDT (History)
1 user (show)

See Also:


Attachments
Patch (1.44 KB, patch)
2013-05-23 13:46 PDT, Anders Carlsson
jberlin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2013-05-23 13:43:51 PDT
Don't run all plug-ins unsandboxed
Comment 1 Anders Carlsson 2013-05-23 13:46:08 PDT
Created attachment 202739 [details]
Patch
Comment 2 Anders Carlsson 2013-05-23 13:46:25 PDT
<rdar://problem/13975569>
Comment 3 Anders Carlsson 2013-05-23 13:48:26 PDT
Committed r150610: <http://trac.webkit.org/changeset/150610>
Comment 4 Csaba Osztrogonác 2013-05-23 21:53:20 PDT
(In reply to comment #3)
> Committed r150610: <http://trac.webkit.org/changeset/150610>

It broke the build on Qt because of a serious warning:

/ramdisk/qt-linux-32-release-webkit2/build/Source/WebKit2/UIProcess/WebPageProxy.cpp: In member function 'void WebKit::WebPageProxy::findPlugin(const WTF::String&, uint32_t, const WTF::String&, const WTF::String&, const WTF::String&, bool, uint64_t&, WTF::String&, uint32_t&)':
/ramdisk/qt-linux-32-release-webkit2/build/Source/WebKit2/UIProcess/WebPageProxy.cpp:1440:155: error: 'pluginProcessSandboxPolicy' may be used uninitialized in this function [-Werror=uninitialized]

I think pluginProcessSandboxPolicy should be always initialized, but it 
isn't if pluginLoadPolicy is pluginModuleBlocked or pluginModuleInactive.

Could you fix it, please?
Comment 5 Csaba Osztrogonác 2013-05-23 22:02:00 PDT
new bug report for it - https://bugs.webkit.org/show_bug.cgi?id=116699