Bug 116688 - [WK2][CoordinatedGraphics] Misuse of DrawingAreaProxy::setVisibleContentsRect() in WebView::updateViewportSize()
Summary: [WK2][CoordinatedGraphics] Misuse of DrawingAreaProxy::setVisibleContentsRect...
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Marcelo Lira
Depends on:
Reported: 2013-05-23 12:55 PDT by Marcelo Lira
Modified: 2013-05-27 09:51 PDT (History)
10 users (show)

See Also:

Patch (3.64 KB, patch)
2013-05-23 12:59 PDT, Marcelo Lira
no flags Details | Formatted Diff | Diff
Patch (3.95 KB, patch)
2013-05-24 11:09 PDT, Marcelo Lira
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Marcelo Lira 2013-05-23 12:55:02 PDT
Currently WebView::updateViewportSize() is calling DrawingAreaProxy::setVisibleContentsRect() passing a rectangle consisting of the page content position and the viewport size scaled to the device's scale factor. But setVisibleContentsRect expects a rectangle describing the page content area that is actually seen, and that should include the page scale factor. Also, the area should not be beyond the page contents boundaries.
Comment 1 Marcelo Lira 2013-05-23 12:59:53 PDT
Created attachment 202737 [details]
Comment 2 Noam Rosenthal 2013-05-24 02:12:43 PDT
Comment on attachment 202737 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=202737&action=review

> Source/WebKit2/ChangeLog:3
> +        [WK2] Misuse of DrawingAreaProxy::setVisibleContentsRect() in WebView::updateViewportSize()

You should update this to reflect the new bug title.

> Source/WebKit2/ChangeLog:10
> +        Visible contents area passed to DrawingAreaProxy::setVisibleContentsRect()
> +        must include page scale factor and avoid crossing the contents
> +        boundaries.

Can you explain why, what is the implications of this and how it is fixed?
Comment 3 Marcelo Lira 2013-05-24 11:09:11 PDT
Created attachment 202837 [details]
Comment 4 WebKit Commit Bot 2013-05-27 09:51:54 PDT
Comment on attachment 202837 [details]

Clearing flags on attachment: 202837

Committed r150764: <http://trac.webkit.org/changeset/150764>
Comment 5 WebKit Commit Bot 2013-05-27 09:51:57 PDT
All reviewed patches have been landed.  Closing bug.