Bug 116688 – [WK2][CoordinatedGraphics] Misuse of DrawingAreaProxy::setVisibleContentsRect() in WebView::updateViewportSize()

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Marcelo Lira]

Currently WebView::updateViewportSize() is calling DrawingAreaProxy::setVisibleContentsRect() passing a rectangle consisting of the page content position and the viewport size scaled to the device's scale factor. But setVisibleContentsRect expects a rectangle describing the page content area that is actually seen, and that should include the page scale factor. Also, the area should not be beyond the page contents boundaries.

[Marcelo Lira]

Created attachment 202737 [details]
Patch

[Noam Rosenthal]

Comment on attachment 202737 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=202737&action=review

> Source/WebKit2/ChangeLog:3
> +        [WK2] Misuse of DrawingAreaProxy::setVisibleContentsRect() in WebView::updateViewportSize()

You should update this to reflect the new bug title.

> Source/WebKit2/ChangeLog:10
> +        Visible contents area passed to DrawingAreaProxy::setVisibleContentsRect()
> +        must include page scale factor and avoid crossing the contents
> +        boundaries.

Can you explain why, what is the implications of this and how it is fixed?

[Marcelo Lira]

Created attachment 202837 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 202837 [details]
Patch

Clearing flags on attachment: 202837

Committed r150764: <http://trac.webkit.org/changeset/150764>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.