Currently WebView::updateViewportSize() is calling DrawingAreaProxy::setVisibleContentsRect() passing a rectangle consisting of the page content position and the viewport size scaled to the device's scale factor. But setVisibleContentsRect expects a rectangle describing the page content area that is actually seen, and that should include the page scale factor. Also, the area should not be beyond the page contents boundaries.
Created attachment 202737 [details]
Comment on attachment 202737 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=202737&action=review
> + [WK2] Misuse of DrawingAreaProxy::setVisibleContentsRect() in WebView::updateViewportSize()
You should update this to reflect the new bug title.
> + Visible contents area passed to DrawingAreaProxy::setVisibleContentsRect()
> + must include page scale factor and avoid crossing the contents
> + boundaries.
Can you explain why, what is the implications of this and how it is fixed?
Created attachment 202837 [details]
Comment on attachment 202837 [details]
Clearing flags on attachment: 202837
Committed r150764: <http://trac.webkit.org/changeset/150764>
All reviewed patches have been landed. Closing bug.