Bug 116682 – Move posix_spawn onto a zero delay timer

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Gavin Barraclough]

<rdar://problem/13973468>

[Gavin Barraclough]

Created attachment 202728 [details]
Fix

[Gavin Barraclough]

Fixed in r150595

[Geoffrey Garen]

Comment on attachment 202728 [details]
Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=202728&action=review

> Source/WebKit2/Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.Development.mm:119
> +                CFRunLoopTimerContext context = { 0, info, NULL, NULL, NULL };
> +                CFRunLoopTimerRef timer = CFRunLoopTimerCreate(NULL, CFAbsoluteTimeGetCurrent(), 0, 0, 0, reexecCallBack, &context);
> +                CFRunLoopAddTimer(CFRunLoopGetCurrent(), timer, kCFRunLoopCommonModes);

Aren't you leaking this timer?

[Darin Adler]

Comment on attachment 202728 [details]
Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=202728&action=review

> Source/WebKit2/Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.Development.mm:79
> +    posix_spawnattr_destroy(&attr);

I don’t understand our approach on memory allocation. We are deallocating this, but not info, info->environment, the strings in info->environment, or timer. Why deallocate anything? Why not deallocate everything?

[Gavin Barraclough]

This code was already leaky – it always immediately calls posix_spawn with flags to perform an execv – so the process is going to be be completely replaced (or will exit).