Bug 116674 - [BlackBerry] Validate form data before doing direct submission.
Summary: [BlackBerry] Validate form data before doing direct submission.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mike Fenton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-23 07:26 PDT by Mike Fenton
Modified: 2013-05-23 08:54 PDT (History)
1 user (show)

See Also:

Attachments
Validation patch. (2.69 KB, patch)
2013-05-23 07:30 PDT, Mike Fenton 		xan.lopez: review-
Details | Formatted Diff | Diff
tabIndex patch (9.59 KB, patch)
2013-05-23 07:31 PDT, Mike Fenton 		no flags Details | Formatted Diff | Diff
Updated Patch (2.70 KB, patch)
2013-05-23 08:10 PDT, Mike Fenton 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Fenton 2013-05-23 07:26:13 PDT 
Two fixes:

1) Improve the submission trigger to validate the form.
2) Respect TabIndex when calculating next/prev elements.
Comment 1 Mike Fenton 2013-05-23 07:30:37 PDT 
Created attachment 202711 [details]
Validation patch.
Comment 2 Mike Fenton 2013-05-23 07:31:21 PDT 
Created attachment 202712 [details]
tabIndex patch
Comment 3 Mike Fenton 2013-05-23 08:04:32 PDT 
Comment on attachment 202712 [details]
tabIndex patch

Clearing flags, moved to new bug 116676.
Comment 4 Xan Lopez 2013-05-23 08:06:27 PDT 
Comment on attachment 202711 [details]
Validation patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=202711&action=review

> Source/WebKit/blackberry/ChangeLog:3
> +        [BlackBerry] Improve input form control handling.

We should do one patch per bug. I suggest we rename this to something related to form validation, and move the other patch elsewhere.

> Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:1022
> +        formElement->submit();

Makes sense to me otherwise, seems it just moves code around to check validity before doing submit(). So please rename the title to land it!
Comment 5 Mike Fenton 2013-05-23 08:10:07 PDT 
Created attachment 202716 [details]
Updated Patch
Comment 6 Xan Lopez 2013-05-23 08:12:21 PDT 
Comment on attachment 202716 [details]
Updated Patch

r=me
Comment 7 WebKit Commit Bot 2013-05-23 08:54:56 PDT 
Comment on attachment 202716 [details]
Updated Patch

Clearing flags on attachment: 202716

Committed r150587: <http://trac.webkit.org/changeset/150587>
Comment 8 WebKit Commit Bot 2013-05-23 08:54:58 PDT 
All reviewed patches have been landed.  Closing bug.