Bug 116666 - [CMake] Add generation of JITStubs for x86_64 MSVC
Summary: [CMake] Add generation of JITStubs for x86_64 MSVC
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Patrick R. Gansterer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-23 06:13 PDT by Patrick R. Gansterer
Modified: 2013-07-04 02:16 PDT (History)
3 users (show)

See Also:

Attachments
Patch (3.47 KB, patch)
2013-05-23 06:17 PDT, Patrick R. Gansterer 		laszlo.gombos: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2013-05-23 06:13:48 PDT 
[CMake] Add generation of JITStubs for x86_64 MSVC
Comment 1 Patrick R. Gansterer 2013-05-23 06:17:47 PDT 
Created attachment 202702 [details]
Patch
Comment 2 Build Bot 2013-05-23 06:52:58 PDT 
Comment on attachment 202702 [details]
Patch

Attachment 202702 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/639092
Comment 3 Laszlo Gombos 2013-06-20 11:39:29 PDT 
Comment on attachment 202702 [details]
Patch

Lets try to run EWS again..
Comment 4 Laszlo Gombos 2013-06-20 11:44:33 PDT 
Comment on attachment 202702 [details]
Patch

This looks good to me. Please make sure the win EWS failure is unrelated before committing.

We should continue to discuss the usage of WTF_CPU_XXX CMake variables at bug 116662 .
Comment 5 Raphael Kubo da Costa (:rakuco) 2013-06-20 11:50:52 PDT 
Comment on attachment 202702 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=202702&action=review

> Source/JavaScriptCore/ChangeLog:9
> +        since it's compiler specific and not dedecated to Windwos CE.

nitpick: dedecated -> dedicated, Windwos -> Windows.
Comment 6 Patrick R. Gansterer 2013-07-04 02:16:57 PDT 
Committed r152395: <http://trac.webkit.org/changeset/152395>