Bug 116660 - Remove [NoInterfaceObject] from FileReaderSync and WorkerLocation
Summary: Remove [NoInterfaceObject] from FileReaderSync and WorkerLocation
Status: RESOLVED LATER
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on: 116708
Blocks: 115853
  Show dependency tree / graph
 
Reported: 2013-05-23 05:05 PDT by Chris Dumez
Modified: 2013-06-04 01:01 PDT (History)
9 users (show)

See Also:

Attachments
Patch (17.69 KB, patch)
2013-05-23 06:52 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2013-05-23 05:05:03 PDT 
According to their respective specs, FileReaderSync and WorkerLocation should not have [NoInterfaceObject] IDL extended attribute:
http://dev.w3.org/2006/webapi/FileAPI/#FileReaderSync
http://dev.w3.org/html5/workers/#workerlocation

This is blocking Bug 115853 as these interfaces have constructors on the WorkerContext object.
Comment 1 Chris Dumez 2013-05-23 06:52:50 PDT 
Created attachment 202703 [details]
Patch
Comment 2 Kentaro Hara 2013-05-23 07:00:14 PDT 
Comment on attachment 202703 [details]
Patch

looks ok
Comment 3 WebKit Commit Bot 2013-05-23 08:19:54 PDT 
Comment on attachment 202703 [details]
Patch

Clearing flags on attachment: 202703

Committed r150586: <http://trac.webkit.org/changeset/150586>
Comment 4 WebKit Commit Bot 2013-05-23 08:19:59 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Chris Dumez 2013-05-23 09:44:59 PDT 
Reverted r150586 for reason:

Those constructors should be exposed on the WorkerContext, not the DOMWindow

Committed r150590: <http://trac.webkit.org/changeset/150590>
Comment 6 Chris Dumez 2013-06-04 01:01:57 PDT 
Those will be removed once we automatically generate WorkerContext constructor attributes.