Bug 116653 - Remove special case for MessagePortArray from bindings generator
Summary: Remove special case for MessagePortArray from bindings generator
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: http://dev.w3.org/html5/postmsg/#even...
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-23 00:51 PDT by Chris Dumez
Modified: 2013-05-23 05:22 PDT (History)
9 users (show)

See Also:


Attachments
Patch (16.53 KB, patch)
2013-05-23 03:35 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2013-05-23 00:51:09 PDT
We should use MessagePort[] instead of MessagePortArray in the IDL to match the spec and avoid special casing in the bindings generator.
Comment 1 Chris Dumez 2013-05-23 03:35:10 PDT
Created attachment 202655 [details]
Patch
Comment 2 Kentaro Hara 2013-05-23 04:05:09 PDT
Comment on attachment 202655 [details]
Patch

Looks good.

Nit: Should we use MessagePort[] or sequence<MessagePort>?
Comment 3 Chris Dumez 2013-05-23 04:07:26 PDT
(In reply to comment #2)
> (From update of attachment 202655 [details])
> Looks good.
> 
> Nit: Should we use MessagePort[] or sequence<MessagePort>?

http://dev.w3.org/html5/postmsg/#event-definitions says MessagePort[]? but I did not make it nullable as I did not want to change the behavior in this patch.

FYI, preparing a similar patch for Blink.
Comment 4 Kentaro Hara 2013-05-23 04:08:23 PDT
OK, let's go with MessagePort[] :)
Comment 5 WebKit Commit Bot 2013-05-23 05:22:04 PDT
Comment on attachment 202655 [details]
Patch

Clearing flags on attachment: 202655

Committed r150580: <http://trac.webkit.org/changeset/150580>
Comment 6 WebKit Commit Bot 2013-05-23 05:22:07 PDT
All reviewed patches have been landed.  Closing bug.