Bug 116639 - Fix assertion in the getComputedStyle-background-shorthand.html test
Summary: Fix assertion in the getComputedStyle-background-shorthand.html test
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-22 15:08 PDT by Simon Fraser (smfr)
Modified: 2013-05-22 15:19 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.51 KB, patch)
2013-05-22 15:13 PDT, Simon Fraser (smfr) 		rniwa: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2013-05-22 15:08:59 PDT 
Fix assertion in the getComputedStyle-background-shorthand.html test
Comment 1 Simon Fraser (smfr) 2013-05-22 15:13:15 PDT 
Created attachment 202627 [details]
Patch
Comment 2 Ryosuke Niwa 2013-05-22 15:16:21 PDT 
Comment on attachment 202627 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=202627&action=review

> Source/WebCore/rendering/RenderObject.cpp:2527
> +    if (!isText()) {

I wish we had a way to assert that this is the only case we have to worry about.
Comment 3 Simon Fraser (smfr) 2013-05-22 15:19:20 PDT 
https://trac.webkit.org/r150547